msg69090 - (view) |
Author: Andrii V. Mishkovskyi (mishok13) |
Date: 2008-07-02 13:32 |
Multiprocessing docs contain examples, that are not valid py3k code, mostly because of print used as a statement. Example (taken from multiprocessing.rst): from multiprocessing import Process def f(name): print 'hello', name if __name__ == '__main__': p = Process(target=f, args=('bob',)) p.start() p.join() If no one is working on this already, than I'll start fixing this and will present a patch in 2 or 3 days. |
|
|
msg69091 - (view) |
Author: Jesse Noller (jnoller) *  |
Date: 2008-07-02 13:42 |
If you're willing to make the patch - I can review and submit. I appreciate it |
|
|
msg69401 - (view) |
Author: Andrii V. Mishkovskyi (mishok13) |
Date: 2008-07-07 22:20 |
So, after 5 days of silence I present my current status on the patch. This patch fixes Doc/includes/mp_*.py examples, except for the fact that I couldn't make mp_distributing.py work, but I'm still working on this issue. |
|
|
msg69402 - (view) |
Author: Andrii V. Mishkovskyi (mishok13) |
Date: 2008-07-07 22:23 |
And this patch is for Doc/library/multiprocessing.rst. Still, there are lot of issues, and as you none of you (Jesse or Richard) answered my email, I'll post them tomorrow here. Right now, the patch. :) |
|
|
msg69403 - (view) |
Author: Jesse Noller (jnoller) *  |
Date: 2008-07-07 22:40 |
Thanks - sorry I didn't reply to the mail yet, had to deal with some other stuff first, I should be freed up tonight |
|
|
msg69417 - (view) |
Author: Andrii V. Mishkovskyi (mishok13) |
Date: 2008-07-08 07:27 |
OK, then ignore the previous email, I'll send you a new one, with updated questions. |
|
|
msg70175 - (view) |
Author: Andrii V. Mishkovskyi (mishok13) |
Date: 2008-07-23 15:41 |
Here is the updated version of multiprocessing.rst patch. Not much has changes, as you can see (if you've seen the previous version, of course ;) ). I have only one question left about multiprocessing.rst, it's about 'allow_connection_pickling' function -- should documentation cover this function or just leave it as it is? The only issue I still have is mp_distributing.py example, which is not properly documented. Jesse, I think you should review both patches and leave this issue open until mp_distributing.py is documented. If you have any questions -- ping me on #python-dev. |
|
|
msg70215 - (view) |
Author: Andrii V. Mishkovskyi (mishok13) |
Date: 2008-07-24 16:57 |
btw, some of the docstrings are also outdated, e.g. Pool.imap, Pool.map, etc. Should I handle this one too? |
|
|
msg70217 - (view) |
Author: Jesse Noller (jnoller) *  |
Date: 2008-07-24 17:26 |
that's your call Andrii |
|
|
msg70224 - (view) |
Author: Andrii V. Mishkovskyi (mishok13) |
Date: 2008-07-24 20:48 |
OK, I'll work on this too. :) Patch should be ready by Monday. |
|
|
msg76998 - (view) |
Author: Georg Brandl (georg.brandl) *  |
Date: 2008-12-05 10:13 |
The docstrings are now fixed too. |
|
|