Issue 4492: httplib code thinks it closes connection, but does not (original) (raw)

Created on 2008-12-02 18:15 by jjlee, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (4)
msg76764 - (view) Author: John J Lee (jjlee) Date: 2008-12-02 18:15
The fix for #900744 tried to close the connection when a bad chunk length was received. The comment inserted with that fix "close the connection as protocol synchronisation is probably lost" is incorrect: self.close() in _read_chunked does not close the connection. You have to call HTTPConnection.close() to close the connection. So: * The comment is incorrect, and should be removed or fixed. I guess the self.close() should stay. * It's probably a bug that it doesn't result in the connection being closed. I guess a fix for that would be for the HTTPResponse to set some state on itself that HTTPConnection can query so that HTTPConnection can close itself the next time somebody tries to do something with the connection.
msg109659 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-07-09 01:24
John could you provide a patch for this?
msg131487 - (view) Author: ysj.ray (ysj.ray) Date: 2011-03-20 12:09
Another fix could be making HTTPResponse to hold a reference to the HTTPConnection object and call its close() at the time of a bad chunk length was received. This can close the connection as soon as possible.
msg401705 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-09-13 14:51
The code has changed quite a lot since this was created and it no longer matches the description in this issue.
History
Date User Action Args
2022-04-11 14:56:42 admin set github: 48742
2021-09-13 14:51:11 iritkatriel set status: open -> closednosy: + iritkatrielmessages: + resolution: out of datestage: test needed -> resolved
2014-02-03 15:39:58 BreamoreBoy set nosy: - BreamoreBoy
2013-12-28 02:16:57 martin.panter set nosy: + martin.panter
2013-12-17 20:14:02 serhiy.storchaka set stage: needs patch -> test needed
2011-03-20 14:40:13 orsenthil set assignee: orsenthilnosy: + orsenthil
2011-03-20 12:09:24 ysj.ray set nosy:jjlee, dstanek, flox, ysj.ray, BreamoreBoy, gennadmessages: +
2011-03-17 14:58:24 ysj.ray set nosy: + ysj.ray
2011-03-17 10:45:31 gennad set nosy: + gennad
2011-03-16 22:19:40 flox set nosy: + flox
2011-01-26 17:54:16 dstanek set nosy: + dstanek
2010-07-09 01:25:00 BreamoreBoy set versions: + Python 3.1, Python 3.2, - Python 2.6, Python 3.0nosy: + BreamoreBoymessages: + stage: needs patch
2008-12-02 18:15:19 jjlee create