Issue 4578: compiler: -3 warnings (original) (raw)

Created on 2008-12-07 17:35 by srittau, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (4)
msg77238 - (view)	Author: Sebastian Rittau (srittau) *	Date: 2008-12-07 17:35
The attached patch replaces all instances of "x.has_key(k)" method calls by "k in x". It also replaces one call to parser.ast2tuple by parser.st2tuple. This removes deprecation warnings when running in -3 mode.
msg77271 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2008-12-07 22:32
Since the compiler package is removed in Python 3, I think it's okay for it to raise py3k warnings -- in fact, it should raise a quite prominent one when first imported that it's going to be removed.
msg77276 - (view)	Author: Sebastian Rittau (srittau) *	Date: 2008-12-07 23:19
I'd like to see this fixed, just to decrease the amount of warning spam I get when testing my own packages. It seems that one of my dependecies that I have no control over is pulling this in. Adding a warning when this module is important seems like a good idea, though.
msg77854 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2008-12-15 08:59
OK, since it doesn't do any damage I've applied your patch in r67787.