Issue 4597: EvalFrameEx fails to set 'why' for some exceptions (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/48847

classification

Title: EvalFrameEx fails to set 'why' for some exceptions
Type: behavior Stage: commit review
Components: Interpreter Core Versions: Python 3.0, Python 3.1, Python 2.7, Python 2.6

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: jyasskin Nosy List: amaury.forgeotdarc, jyasskin, loewis, nnorwitz
Priority: normal Keywords: patch

Created on 2008-12-08 17:52 by jyasskin, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fix_exceptions.patch jyasskin,2008-12-08 17:52
Messages (6)
msg77332 - (view) Author: Jeffrey Yasskin (jyasskin) * (Python committer) Date: 2008-12-08 17:52
Several opcodes that can raise an exception fail to set x, err, or why afterward. This patch fixes all the examples I could find. I could only figure out how to write a test for PRINT_NEWLINE; the others are hard to trigger.
msg77334 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2008-12-08 18:14
The patch looks good. These problems also apply to 2.5 I assume? You might want to ping MvL to let him know since he's about to cut that release.
msg77335 - (view) Author: Jeffrey Yasskin (jyasskin) * (Python committer) Date: 2008-12-08 18:56
Submitted as r67666. I'll ping Martin.
msg77358 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2008-12-08 22:58
This is fine to port to 2.5; please go ahead. Don't forget to add Misc/NEWS entries, though - also add them for the branches you have changed already.
msg77576 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2008-12-10 23:06
Reopening: this need to be manually merged into 2.6 and 3.0 maintenance branches. + a NEWS entry is still missing.
msg77593 - (view) Author: Jeffrey Yasskin (jyasskin) * (Python committer) Date: 2008-12-11 06:39
Added NEWS in r67685; ported to 2.5 branch in r67687; to 2.6 branch in r67696; to 3.1 branch in r67697; and to 3.0 branch in r67698.
History
Date User Action Args
2022-04-11 14:56:42 admin set github: 48847
2008-12-11 06:39:49 jyasskin set status: open -> closedmessages: +
2008-12-10 23:06:28 amaury.forgeotdarc set status: closed -> opennosy: + amaury.forgeotdarcmessages: + stage: resolved -> commit review
2008-12-08 22:58:48 loewis set nosy: + loewismessages: +
2008-12-08 18:56:26 jyasskin set status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2008-12-08 18:14:06 nnorwitz set keywords: - needs reviewnosy: + nnorwitzmessages: +
2008-12-08 17:52:12 jyasskin create