Issue 4991: os.fdopen doesn't raise on invalid file descriptors (original) (raw)

Created on 2009-01-18 21:02 by benjamin.peterson, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (8)
msg80125 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2009-01-18 21:02
Since os.fdopen is now implemented with io.open, it doesn't use fdopen and check for invalid file descriptors. This isn't a huge issue since subsequent actions on the file will raise an error.
msg80128 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2009-01-18 21:23
Perhaps io.open should be fixed, then? (or the _FileIO constructor)
msg80130 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2009-01-18 21:54
Here's a patch for _FileIO.
msg80135 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2009-01-18 23:21
I think EBADF is defined everywhere, so you can drop the defined() conditional.
msg80136 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2009-01-18 23:52
Attaching new patch...
msg80137 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2009-01-19 00:03
I'm not sure Windows has a valid fstat btw, I'll guess we'll see on the Windows buildbots (in that case, some code can be taken from posixmodule.c to emulate fstat behaviour...). Other than that, the patch looks fine to me.
msg80138 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2009-01-19 00:09
Applied in r68755. Will watch Windows.
msg80176 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2009-01-19 15:14
Well, the Windows bot is failing but not from test_fileio, so I'll go ahead and merge it. r68767.