msg81979 - (view) |
Author: Armandas (armandas) |
Date: 2009-02-14 00:04 |
When custom dictionary is used to create a completer, rlcompleter still uses __builtins__.__dict__ to search for completions (rlcompleter.py, global_matches()): for nspace in [builtins.__dict__, self.namespace]: ... This behaviour may sometimes be unwanted. It would be nice to have an option, which when set would tell completer to only use provided dictionary. |
|
|
msg113154 - (view) |
Author: Michele Orrù (maker) * |
Date: 2010-08-07 07:27 |
The attached patch fixes this issue and provides some tests. |
|
|
msg113169 - (view) |
Author: Éric Araujo (eric.araujo) *  |
Date: 2010-08-07 12:04 |
The report says “This behaviour may sometimes be unwanted. It would be nice to have an option”, so I’m requalifying as a RFE and adjusting versions. The patch changes behavior (search order was builtins, self.namespace and is now reversed), is this wanted? The patch also needs to update the doc. Thanks! |
|
|
msg113180 - (view) |
Author: Michele Orrù (maker) * |
Date: 2010-08-07 15:21 |
Yes, it is. I think the user would expect that kind of behaviour. The attached patch updates the Doc. |
|
|
msg172914 - (view) |
Author: Éric Araujo (eric.araujo) *  |
Date: 2012-10-14 20:24 |
Looks good to me. I wrote one comment on the doc patch review. |
|
|
msg172921 - (view) |
Author: Michele Orrù (maker) * |
Date: 2012-10-14 20:59 |
Updated with tip, and merged with documentation. |
|
|
msg172955 - (view) |
Author: Ezio Melotti (ezio.melotti) *  |
Date: 2012-10-15 10:37 |
I would make the argument keyword-only. Changing the logic to avoid eval() might be OK, but IIUC is not related to this issue, and it should be done separately. The markup in the doc could be better (`...` should be ``...`` or a more specific directive that generates a link). A versionchanged should be added as well. |
|
|
msg172999 - (view) |
Author: Michele Orrù (maker) * |
Date: 2012-10-15 20:08 |
Updated. Note that removing `eval` is necessary for the new logic of the function. |
|
|
msg348652 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2019-07-29 12:02 |
This issue is not newcomer friendly, I remove the easy keyword. |
|
|