Issue 5306: Python 3.1 won't compile under Visual Studio 2005 (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/49556

classification

Title: Python 3.1 won't compile under Visual Studio 2005
Type: compile error Stage:
Components: Interpreter Core Versions: Python 3.1

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: amaury.forgeotdarc Nosy List: amaury.forgeotdarc, benjamin.peterson, kristjan.jonsson, loewis, ocean-city, rhettinger
Priority: critical Keywords: patch

Created on 2009-02-18 22:30 by rhettinger, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fix_posixmodule.patch ocean-city,2009-02-19 04:00
Messages (9)
msg82435 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2009-02-18 22:30
This started happening a few days ago, about when Benjamin forward ported r69560 . There is an #ifdef in fileobject.h that makes a header for int _PyVerify_fd(int fd) but does not define it. It is likely related to r69495 . _fileio.obj : error LNK2019: unresolved external symbol __PyVerify_fd referenced in function _check_fd C:\py31\PC\VS8.0\\python31_d.dll : fatal error LNK1120: 1 unresolved externals
msg82441 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2009-02-18 23:07
I don't feel responsible for VS2005 support. Unassigning myself.
msg82443 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2009-02-18 23:40
Kristan, I think this is yours.
msg82452 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-02-19 04:00
I think change for posixmodule.c is missing from r69495. (I confirmed other merges don't include posixmodule.c modification) Attached patch will fix this. (I don't have VS2005 or later, so I cannot test this on my machine)
msg82453 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-02-19 04:02
And I think r69268 should be merged too.
msg82454 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2009-02-19 04:07
Benjamin, please use this patch to complete the merge.
msg82467 - (view) Author: Kristján Valur Jónsson (kristjan.jonsson) * (Python committer) Date: 2009-02-19 09:37
Ah, I just saw this. Yes, looks like a missing file during porting. That should affect VS2008 as well. Cheers!
msg82489 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-02-19 19:45
Could one of the Windows experts do the port? I can't properly resolve the conflicts or test the changes here.
msg82506 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2009-02-19 23:23
I merged the change manually, and came to the same patch as ocean-city; Then I noticed that os.device_encoding() (new in python 3.0) needs the same check as well.
History
Date User Action Args
2022-04-11 14:56:45 admin set github: 49556
2009-02-19 23:23:50 amaury.forgeotdarc set status: open -> closedresolution: fixedmessages: +
2009-02-19 23:15:38 amaury.forgeotdarc set assignee: amaury.forgeotdarcnosy: + amaury.forgeotdarc
2009-02-19 19:45:55 benjamin.peterson set assignee: benjamin.peterson -> (no value)messages: +
2009-02-19 09:37:22 kristjan.jonsson set messages: +
2009-02-19 07:30:44 rhettinger set priority: high -> critical
2009-02-19 04:07:41 rhettinger set assignee: kristjan.jonsson -> benjamin.petersonmessages: + nosy: + benjamin.peterson
2009-02-19 04:02:16 ocean-city set messages: +
2009-02-19 04:00:12 ocean-city set files: + fix_posixmodule.patchnosy: + ocean-citymessages: + keywords: + patch
2009-02-18 23:40:15 rhettinger set assignee: kristjan.jonssonmessages: + nosy: + kristjan.jonsson
2009-02-18 23:07:01 loewis set assignee: loewis -> (no value)messages: +
2009-02-18 22:30:07 rhettinger create