Issue 5369: ppc macro checking is incorrect (original) (raw)

Issue5369

Created on 2009-02-25 19:26 by arekm, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
3.0-issue5369.patch wiget,2009-03-28 10:22
Messages (2)
msg82712 - (view) Author: Arkadiusz Miƛkiewicz (arekm) Date: 2009-02-25 19:26
Python/ceval.c and many other places rely on __ppc__ (and __ppc64__) symbol defined like below. Unfortunately on my Linux ppc __ppc__ is never defined while __powerpc__ is. Build fortunately failed so the problem was noticed. The fix is to check for __powerpc__ and __powerpc64__ as for example glibc does. #if defined(__ppc__) /* <- Don't know if this is the correct symbol; this section should work for GCC on any PowerPC platform, irrespective of OS. POWER? Who knows :-) */
msg84301 - (view) Author: Artur Frysiak (wiget) Date: 2009-03-28 10:22
__ppc__ is defined on MacOS X, __powerpc__ on Linux. Only place when need check for both is Python/ceval.c
History
Date User Action Args
2022-04-11 14:56:46 admin set github: 49619
2011-01-06 16:48:34 pitrou set status: open -> closedresolution: duplicatesuperseder: Wrong powerpc define in Python/ceval.c
2009-03-28 10:26:38 wiget set versions: + Python 3.1
2009-03-28 10:22:08 wiget set files: + 3.0-issue5369.patchnosy: + wigetmessages: + keywords: + patch
2009-02-25 19:26:06 arekm create