Issue 5499: only accept byte for getarg('c') and unicode for getarg('C') (original) (raw)

Issue5499

Created on 2009-03-17 12:58 by vstinner, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (6)
msg83676 - (view)	Author: STINNER Victor (vstinner) *	Date: 2009-03-17 12:58
To avoid byte/character mixture, getarg('c') must only accept a byte string of 1 byte and getarg('C') only an unicode string of 1 character. Impacted methods: - datetime.datetime.isoformat(sep), array.array(type, data): don't accept byte anymore - msvcrt.putch(char), msvcrt.ungetch(char), .write_byte(char): don't accept unicode anymore I tried runtests.sh: only the 3 bytes.{center,ljust,rjust} tests have to be changed, all other tests are ok. Related issues: #3446, #5391.
msg83687 - (view)	Author: STINNER Victor (vstinner) *	Date: 2009-03-17 17:25
unicode methods center(), ljust(), rjust() use a callback (convert_uc) to get an unicode character (unicode string of 1 character). If 'C' is fixed, convert_uc() callback can be removed.
msg84874 - (view)	Author: Hirokazu Yamamoto (ocean-city) *	Date: 2009-03-31 19:25
Note: #5391 and #5410 are depends on this issue.
msg85112 - (view)	Author: Gregory P. Smith (gregory.p.smith) *	Date: 2009-04-01 23:08
good catch. the patch looks correct to me.
msg85124 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2009-04-02 00:34
Fixed in r71013.
msg85181 - (view)	Author: STINNER Victor (vstinner) *	Date: 2009-04-02 08:23
Ooops, I read converterr("a unicode character", ...), but it should be converterr("an unicode character", ...) ;-) Thanks benjamin.peterson, it will help other issues like #5391 and #5410.