Issue 5609: Create Unit Tests for nturl2path module (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/49859

classification

process

Created on 2009-03-30 17:29 by Kozyarchuk, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (7)
msg84590 - (view)	Author: Maksim Kozyarchuk (Kozyarchuk)	Date: 2009-03-30 17:29
Added Unit Tests for nturl2path module. http://codereview.appspot.com/32072/show
msg84591 - (view)	Author: Maksim Kozyarchuk (Kozyarchuk)	Date: 2009-03-30 17:31
Patch is available on Appshot, please review/approve. http://codereview.appspot.com/32072/show
msg111184 - (view)	Author: Mark Lawrence (BreamoreBoy) *	Date: 2010-07-22 15:47
Maksim could you please respond to the comments on Rietveld, thanks.
msg184819 - (view)	Author: Thomas Fenzl (Thomas Fenzl) *	Date: 2013-03-21 00:47
The tests work on linux, so I removed the check for nt. Also I adapted them to the latest implementation using ':' instead of '|' as drive letter separator.
msg185939 - (view)	Author: Thomas Fenzl (Thomas Fenzl) *	Date: 2013-04-03 17:09
The authoritative implementation of this functionality would be Microsoft's PathCreateFromUrl (http://msdn.microsoft.com/en-us/library/windows/desktop/bb773581%28v=vs.85%29.aspx) and UrlCreateFromPath (http://msdn.microsoft.com/en-us/library/windows/desktop/bb773773%28v=vs.85%29.aspx), right? If so I'll run a few more complex conversions and round-trips through those and add the tests
msg185945 - (view)	Author: Senthil Kumaran (orsenthil) *	Date: 2013-04-03 19:39
Thanks for the patch and test coverage. LGTM. I shall verify further and commit it.
msg186542 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-04-11 03:54
New changeset 5f8fe382f9db by Senthil Kumaran in branch '3.3': #5609 - test_urllib coverage for url2pathname and pathname2url. Patch http://hg.python.org/cpython/rev/5f8fe382f9db New changeset 7b3f1c6a67d9 by Senthil Kumaran in branch 'default': merge from 3.3 http://hg.python.org/cpython/rev/7b3f1c6a67d9