Issue 6032: Fix refleaks in test_urllib2_localnet (original) (raw)

Created on 2009-05-16 00:47 by collinwinter, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (6)
msg87846 - (view)	Author: Collin Winter (collinwinter) *	Date: 2009-05-16 00:47
Currently (r72673), test_urllib2_localnet leaks references. This is due to state implicitly shared between tests. The attached patch fixes this by removing the shared state. The problem is also present in py3k. I'll port the patch once I commit to trunk. Should this be backported so we can take test_urllib2_localnet off the refleak test blacklist in Misc/build.sh in those branches?
msg87847 - (view)	Author: Daniel Diniz (ajaksu2) *	Date: 2009-05-16 01:07
Collin, This the fix for issue 6002, right? Does issue 1208304 also cause leaks in your tests?
msg87848 - (view)	Author: Collin Winter (collinwinter) *	Date: 2009-05-16 01:11
Yes, this is a patch for issue 6002 (sorry, didn't find it). I haven't seen any refleaks from issue 1208304, but I was only looking at this one particular failure (since it was showing up in Unladen Swallow's refleak builds).
msg88051 - (view)	Author: Collin Winter (collinwinter) *	Date: 2009-05-18 20:37
Daniel, did you have any comments on this patch? If not, I'll go ahead and commit it and close both of these issues.
msg88053 - (view)	Author: Daniel Diniz (ajaksu2) *	Date: 2009-05-18 21:24
LGTM :) This part changes the output in verbose mode, not sure it's necessary (but not a real problem either): - test_support.run_unittest(ProxyAuthTests) - test_support.run_unittest(TestUrlopen) + test_support.run_unittest(ProxyAuthTests, TestUrlopen)
msg88057 - (view)	Author: Collin Winter (collinwinter) *	Date: 2009-05-18 22:34
Applied as r72777 (trunk), r72778 (py3k).