| msg90402 - (view) |
Author: R. David Murray (r.david.murray) *  |
Date: 2009-07-11 03:09 |
| Another apparent fallout from r73638 (issue 6267). On my gentoo system I am currently seeing a consistent failure in test_xmlrpc of 'test_two' in KeepaliveServerTestCase (as is the Gentoo buildbot). I made the assert the new GreaterEqual and stuck just a tad bit of extra tracing in (printing the contents of myRequests to stderr) and this is what I see: rdmurray@partner:~/python/trunk>./python -m test.regrtest test_xmlrpc Could not find '/home/rdmurray/python/trunk/Lib/test' in sys.path to remove it test_xmlrpc [['POST /RPC2 HTTP/1.1\r\n']] test test_xmlrpc failed -- Traceback (most recent call last): File "/home/rdmurray/python/trunk/Lib/test/test_xmlrpc.py", line 550, in test_two self.assertGreaterEqual(len(self.RequestHandler.myRequests[-1]), 2) AssertionError: 1 not greater than or equal to 2 1 test failed: test_xmlrpc The test appears to hit a time out. If there are any tests you want me to run let me know. Oddly enough I'm not seeing this one on 3.2. |
|
|
| msg90404 - (view) |
Author: Ned Deily (ned.deily) * |
Date: 2009-07-11 06:03 |
| FWIW, I've just seen a couple of intermittent 'test_two' failures with a current py3k on OS X but, in each case, the test passed when auto rerun in verbose mode. test test_xmlrpc failed -- Traceback (most recent call last): File "/Library/Frameworks/Python.framework/Versions/3.2/lib/python3.2/test/te st_xmlrpc.py", line 514, in test_two self.assertTrue(len(self.RequestHandler.myRequests[-1]) >= 2) AssertionError: False is not True |
|
|
| msg90406 - (view) |
Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2009-07-11 08:46 |
| This is probably a race condition, where the server thread hasn't updated the stats yet when the client is testing them. I'm so used to work with non-preemtive scheduling in stackless python that I sometimes forget how threads work :) I submitted revision 73932 for the trunk, please test. |
|
|
| msg90422 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2009-07-11 14:11 |
| OK, the test passes on my box now. But from the way the test is phrased it sounds like there is still a small risk that the test will fail in unusual timing circumstances? |
|
|
| msg90424 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2009-07-11 16:23 |
| By the way, although my system doesn't show it, the Gentoo 3.x buildbot shows the error. I'm sure you were going to forward port the patch anyway :) |
|
|
| msg90435 - (view) |
Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2009-07-11 20:36 |
| No, this should take care of it. In order for the client side request to succeed, the server must have cycled through the previous request and updated its statistic. It is only the statistic for the final request tha t may be missed. And yes, I was going to fw. port, I was waiting for your confirmation. Cheers. |
|
|
| msg90436 - (view) |
Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2009-07-11 21:57 |
| merged testsuite fix to py3k in revision 73961 |
|
|
| msg119169 - (view) |
Author: Sandro Tosi (sandro.tosi) * |
Date: 2010-10-19 21:44 |
| Hello, can we consider this bug as fixed? test has been fixed, buildbots don't show this problem anymore and a run on my system with 300 instances of the test_xmlrpc running in parallel generated only OK as result. Regards, Sandro |
|
|
| msg119172 - (view) |
Author: Ned Deily (ned.deily) * |
Date: 2010-10-19 22:06 |
| I have not seen any recent failures either. |
|
|