Issue 6700: inspect.getsource() returns incorrect source lines at the module level (original) (raw)

Created on 2009-08-14 04:19 by ggenellina, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (8)
msg91541 - (view)	Author: Gabriel Genellina (ggenellina)	Date: 2009-08-14 04:19
inspect.getsource(obj) returns incorrect results when obj is a traceback or frame object outside any function (that is, at the module level). This demo script shows the problem. The correct output should contain all source lines in the module, but it only returns the first two: D:\temp>type show_inspect_bug.py def foo(x): return y + z import inspect frame = inspect.currentframe() print inspect.getsource(frame) D:\temp>python show_inspect_bug.py def foo(x): return y + z The attached patch fixes the problem and adds some missing test cases. Originally reported by Juanjo Conti at the local Python group.
msg102651 - (view)	Author: Daniel Diniz (ajaksu2) *	Date: 2010-04-08 22:59
Confirmed in trunk and py3k. Also affects inspect.getsourcelines.
msg189842 - (view)	Author: James Saryerwinnie (jamesls) *	Date: 2013-05-23 02:56
I confirmed the issue in tip. One of the issues with the original patch is that it modifies the tokeneater method used by getblock which won't work if the first token is any of the special cased tokens in the original patch ('@', 'def', 'class'). I've added additional tests that show where the original patch fails. An alternative approach is to check in getsourcelines whether or not we're dealing with a traceback or frame object in the module scope, and if so, return the lines of the entire module. I've attached an updated patch that implements this along with additional tests.
msg324000 - (view)	Author: Tal Einat (taleinat) *	Date: 2018-08-24 14:18
New changeset 91cb298f811961277fd4cc4a32211899d48bedcb by Tal Einat (Vladimir Matveev) in branch 'master': bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (GH-8864) https://github.com/python/cpython/commit/91cb298f811961277fd4cc4a32211899d48bedcb
msg324002 - (view)	Author: miss-islington (miss-islington)	Date: 2018-08-24 14:41
New changeset 0e707b4c6a47086d8e723c7a010c3f5cf8296946 by Miss Islington (bot) in branch '3.6': bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (GH-8864) https://github.com/python/cpython/commit/0e707b4c6a47086d8e723c7a010c3f5cf8296946
msg324004 - (view)	Author: miss-islington (miss-islington)	Date: 2018-08-24 14:44
New changeset 3e6020c4ddf7acea91efdae770320c6ce06b93db by Miss Islington (bot) in branch '3.7': bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (GH-8864) https://github.com/python/cpython/commit/3e6020c4ddf7acea91efdae770320c6ce06b93db
msg324114 - (view)	Author: Tal Einat (taleinat) *	Date: 2018-08-26 08:45
New changeset 491740f116755e220135e596ec802ea3a0f65596 by Tal Einat in branch '2.7': [2.7] bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (GH-8864) https://github.com/python/cpython/commit/491740f116755e220135e596ec802ea3a0f65596
msg324115 - (view)	Author: Tal Einat (taleinat) *	Date: 2018-08-26 08:47
Thanks for reporting this, Gabriel! Thanks for the PR, Vladimir!