Issue 6838: httplib's _read_chunked extremely slow for lots of chunks (original) (raw)

Issue6838

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification

Title:	httplib's _read_chunked extremely slow for lots of chunks
Type:	Stage:
Components:	Versions:	Python 3.1, Python 3.2, Python 2.7, Python 2.6

process

Status:	closed	Resolution:	fixed
Dependencies:		Superseder:
Assigned To:	cjw296	Nosy List:	cjw296
Priority:	high	Keywords:	easy

Created on 2009-09-04 16:08 by cjw296, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name	Uploaded	Description	Edit
httplib.patch.txt	cjw296,2009-09-04 16:08

Messages (3)
msg92257 - (view)	Author: Chris Withers (cjw296) *	Date: 2009-09-04 16:08
As the comment in this method suggests, accumulating the value by repeated string concatenation is slow. Appending to a list speeds this up dramatically. To quantify this, downloading a 110Mb file from Apache take: ~3s using Internet Explorer 2.2s using wget 30mins using the script in http://mail.python.org/pipermail/python- dev/2009-September/091581.html With the attached patch applied, this time drops to 2.3s.
msg92258 - (view)	Author: Chris Withers (cjw296) *	Date: 2009-09-04 16:12
Fix for trunk committed in r74655.
msg92259 - (view)	Author: Chris Withers (cjw296) *	Date: 2009-09-04 17:15
Fix merged to 2.6, 3.1 and 3.2 branches.

History
Date	User	Action	Args
2022-04-11 14:56:52	admin	set	github: 51087
2009-09-04 17:15:57	cjw296	set	status: open -> closedresolution: fixedmessages: +
2009-09-04 16:12:53	cjw296	set	messages: +
2009-09-04 16:08:39	cjw296	create