Issue 7001: turtle.py bug-fixes, backported from 3.1 [issue5923] (original) (raw)

Issue7001

Created on 2009-09-25 21:02 by gregorlingl, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
turtle_262_263.diff gregorlingl,2009-09-25 21:02 bugfixes for three bugs
turtleDemo_262_263.diff gregorlingl,2009-09-25 21:08 Adding one line, needed as a complement to the bugfixes in turtle_262_263.difff
Messages (5)
msg93142 - (view) Author: Gregor Lingl (gregorlingl) Date: 2009-09-25 21:02
Among the changes of turtle.py from Python 3.0 to Python 3.1 there were three bugfixes. Those bugs appear also in the Python 2.6 version of turtle.py imho these should be fixed for Python 2.6.3 The appended diffs contain the (backported) fixes of these bugs, (1) in TurtleScreen.update() (2) in TurtleScreen.onkey() (3) in _Screen.__init__ and _Screen.setup The last one entails the need of adding one line into turtleDemo.py. This change does not affect the correct working of turtleDemo with the Python 2.6.2 turtle and demos.
msg93143 - (view) Author: Gregor Lingl (gregorlingl) Date: 2009-09-25 21:08
!! This patch should be applied if and only if the corresponding one of turtle.py is applied !!
msg93154 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2009-09-26 03:32
Gregor, just to make sure I understand, these patches need to be applied to trunk (2.7) as well as 2.6, correct?
msg93163 - (view) Author: Gregor Lingl (gregorlingl) Date: 2009-09-26 22:36
These patches need to be applied to 2.6 in order that they appear in 2.6.3. (/python/branches/release26-maint, I think). As far as I see this is urgent because 2.6.3rc1 is only a few days away. Eventually (or, if you want at the same time) they need to be applied to 2.7. But there are quite a few amendments more that should be backported from Python 3.1 to Python 2.7. Moreover, we do not know today, which bugfixes etc. will go into 3.2 and I think 3.2 should be synchronized with 2.7. Since 2.7 still seems to be pretty far away, we can defer this for now and do it later together with the complementing pathes. As already said, it needs to be done eventually, anyhow. Regards, Gregor
msg93225 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2009-09-28 18:58
Committed to trunk in r75115, and 2.6 in r75116. As far as I know there are no tests for this module other than the doctests in the documentation. Those at least run without errors after the patches.
History
Date User Action Args
2022-04-11 14:56:53 admin set github: 51250
2009-09-28 18:58:05 r.david.murray set status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved
2009-09-26 22:36:49 gregorlingl set messages: +
2009-09-26 03:32:22 r.david.murray set priority: normaltype: behaviorassignee: r.david.murrayversions: + Python 2.7nosy: + r.david.murraymessages: + stage: commit review
2009-09-25 21:08:07 gregorlingl set files: + turtleDemo_262_263.diffnosy: + loewis, georg.brandlmessages: +
2009-09-25 21:02:45 gregorlingl create