Issue 7147: Remove WITHOUT_COMPLEX from 3.x trunk (original) (raw)

Issue7147

Created on 2009-10-15 23:45 by skip.montanaro, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
nocomplex.diff skip.montanaro,2009-10-15 23:45
Messages (4)
msg94113 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2009-10-15 23:45
I raised the topic of the use of WITHOUT_COMPLEX in python-dev. Here's a patch to remove it from the 3.x trunk.
msg94131 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2009-10-16 08:50
I think this patch should be applied, on the basis that: - the WITHOUT_COMPLEX macro doesn't appear to be documented, or linked to any existing configure option - there aren't enough developer and/or buildbot cycles to keep obscure options like this well tested and maintained - building py3k with -DWITHOUT_COMPLEX currently fails anyway - the complex type is (slightly) more tightly integrated in py3k than in trunk, thanks to PEP 3141: (-1)**0.5 produces a complex result in py3k; in trunk it gives ValueError. Any objections to getting rid of WITHOUT_COMPLEX? The patch itself looks fine to me.
msg94207 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2009-10-18 07:49
Skip, I think you could just check this in. (Or I can do it if you'd prefer.)
msg94213 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2009-10-18 14:26
Committed revision 75495.
History
Date User Action Args
2022-04-11 14:56:54 admin set github: 51396
2009-10-18 14:26:31 skip.montanaro set status: open -> closedkeywords:patch, patch, easy, needs reviewmessages: +
2009-10-18 07:49:08 mark.dickinson set keywords:patch, patch, easy, needs reviewassignee: skip.montanaroresolution: acceptedmessages: +
2009-10-16 08:50:25 mark.dickinson set keywords:patch, patch, easy, needs reviewnosy: + mark.dickinsonmessages: +
2009-10-15 23:45:02 skip.montanaro create