Issue 7334: ElementTree: file locking in Jython 2.5 (OSError on Windows) (original) (raw)

Created on 2009-11-16 15:56 by gdoutch, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue7334_etree_patch.diff flox,2010-02-16 13:59 Patch, apply to trunk
Messages (10)
msg95349 - (view) Author: Gareth Doutch (gdoutch) Date: 2009-11-16 15:56
I have a problem with an xml file locking after read and/or write. I have a short sample code with unit test available here: http://bugs.jython.org/file741/lock.py Below are the outputs from Jython and CPython (v 2.5.4). I am using Jython 2.5.1 on Windows XP and java version "1.6.0_16". >jython lock.py E ====================================================================== ERROR: runTest (__main__.TestDelete) ---------------------------------------------------------------------- Traceback (most recent call last): File "W:\testTeam\SIT\JySit\sit\scripts\lock.py", line 73, in tearDown os.remove(self.fileName) File "C:\jython2.5.1\Lib\os.py", line 342, in remove raise OSError(0, "couldn't delete file", path) OSError: [Errno 0] couldn't delete file: 'C:\\testdir\\test.xml' ---------------------------------------------------------------------- Ran 1 test in 0.454s FAILED (errors=1) >python lock.py . ---------------------------------------------------------------------- Ran 1 test in 0.015s OK The problem can be cured by applying the changes as per file: http://bugs.jython.org/file742/ElementTree.py
msg95350 - (view) Author: Gareth Doutch (gdoutch) Date: 2009-11-16 16:02
This is on the Jython list: http://bugs.jython.org/issue1479
msg99409 - (view) Author: Florent Xicluna (flox) * (Python committer) Date: 2010-02-16 13:59
The patch proposed on : * need tests * not reviewed (yet)
msg102762 - (view) Author: Philip Jenvey (pjenvey) * (Python committer) Date: 2010-04-10 02:48
Patch with tests (which can only really test it on Windows) here http://bitbucket.org/pjenvey/et-2009-provolone/changeset/8292a06090a3/
msg124621 - (view) Author: Philip Jenvey (pjenvey) * (Python committer) Date: 2010-12-24 23:53
Florent, any chance of signing off on this for 3.2? I was waiting for the patch to go through your authorized elementtree fork
msg146587 - (view) Author: Florent Xicluna (flox) * (Python committer) Date: 2011-10-29 01:09
Changeset cff78ffb932a fixed the issue for 3.2. I will consider backporting.
msg146588 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-10-29 01:39
New changeset eceaa31252b3 by Florent Xicluna in branch '2.7': Closes #7334: close source files on ElementTree.parse and iterparse (partial backport of issue #10093 from 3.2). http://hg.python.org/cpython/rev/eceaa31252b3
msg224713 - (view) Author: Christian Henz (Christian.Henz) Date: 2014-08-04 12:27
I think the cElementTree portion of the applied changes is incorrect. `close_source` is never actually set to `True`. http://hg.python.org/cpython/file/50722d2f08c7/Modules/_elementtree.c#l2926
msg234490 - (view) Author: Martijn Pieters (mjpieters) * Date: 2015-01-22 12:45
Indeed, the 2.7 backport was not correctly applied for _elementtree.c, leaving files open because the close_source flag is set to False *again* when opening a filename. Should a new issue be opened or should this ticket be re-opened?
msg234506 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-01-22 18:36
> Should a new issue be opened or should this ticket be re-opened? It's a 3 years old backport, I'd say open a new issue.
History
Date User Action Args
2022-04-11 14:56:54 admin set github: 51583
2015-01-22 18:36:00 berker.peksag set nosy: + berker.peksagmessages: +
2015-01-22 12:45:52 mjpieters set nosy: + mjpietersmessages: +
2014-08-04 13:41:22 brian.curtin set nosy: - brian.curtin
2014-08-04 12:27:07 Christian.Henz set nosy: + Christian.Henzmessages: +
2011-10-29 01:39:41 python-dev set status: open -> closednosy: + python-devmessages: + stage: patch review -> resolved
2011-10-29 01:09:28 flox set resolution: fixedstage: needs patch -> patch reviewmessages: + versions: - Python 3.2
2010-12-24 23:53:27 pjenvey set assignee: pjenvey -> floxmessages: + nosy:pjenvey, brian.curtin, flox, gdoutch
2010-04-10 02:49:55 brian.curtin set nosy: + brian.curtin
2010-04-10 02:48:45 pjenvey set messages: +
2010-02-16 13:59:10 flox set files: + issue7334_etree_patch.diffpriority: normaltitle: XML file locking in Jython 2.5 (OSError on Windows) -> ElementTree: file locking in Jython 2.5 (OSError on Windows)keywords: + patchnosy: + floxmessages: + stage: needs patch
2009-11-17 04:15:33 pjenvey set assignee: pjenveynosy: + pjenveyversions: + Python 2.7, Python 3.2, - Python 2.5
2009-11-16 16:02:56 gdoutch set messages: +
2009-11-16 15:56:07 gdoutch create