Issue 7440: distutils shows incorrect Python version in MSI installers (original) (raw)

Issue7440

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/51689

classification

process

Created on 2009-12-05 07:49 by MarioVilas, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (5)
msg95984 - (view)	Author: Mario Vilas (MarioVilas)	Date: 2009-12-05 07:49
I just hit this silly bug in distutils, should be quite easy to fix. When building MSI installers for a target_version other than the current Python version, the target directory selection dialog shows a wrong message. For example, here is a screen capture of an installer built using Python 2.6, but setting the target as Python 2.5. The message says: "The destination directory should contain a Python 2.6 installation" when it should be: "The destination directory should contain a Python 2.5 installation".
msg95985 - (view)	Author: Mario Vilas (MarioVilas)	Date: 2009-12-05 07:51
My proposed patch is to change line 506 of bdist_msi.py from this: version = sys.version[:3]+" " to this: version = self.target_version[:3]+" " which is what I did to work around the problem.
msg96577 - (view)	Author: Tarek Ziadé (tarek) *	Date: 2009-12-18 19:19
The patch looks good to me. I am putting Martin on the noselist so he can validate this. Notice that this Dialog has been changed in trunk, so this need to be fixed only in the 2.6 branch.
msg132168 - (view)	Author: Éric Araujo (eric.araujo) *	Date: 2011-03-25 22:13
Is this out of date?
msg132173 - (view)	Author: Martin v. Löwis (loewis) *	Date: 2011-03-25 22:35
Yes, this is out of date since 2416f166de4b