| msg96106 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2009-12-08 02:59 |
| load_pop() pops a value if the stack length is >= 0. The test is wrong: if the length is zero, the stack is empty and stackUnderflow() have to be called. Example: $ ../../python -c "import cPickle; cPickle.loads('0')" Erreur de segmentation |
|
|
| msg96107 - (view) |
Author: Eric V. Smith (eric.smith) * |
Date: 2009-12-08 06:20 |
| Can you add a test for this? |
|
|
| msg96121 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2009-12-08 10:48 |
| > Can you add a test for this? I wasn't sure of the right place to add the test. I tried Lib/test/pickletester.py, but it doesn't work because UnpicklingError is not defined there. Well, here is a new version of my patch with an unit test. |
|
|
| msg96245 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2009-12-11 11:40 |
| Oops, cpickle_load_pop-2.patch contains an useless variable (picklingError = pickle.UnpicklingError). Here is the version 3 of my patch. |
|
|
| msg96273 - (view) |
Author: Jack Diederich (jackdied) * |
Date: 2009-12-11 21:01 |
| This seems to have been introduced in r72930 when the stackUnderflow() was moved from the top of the function to the bottom. It used to test for len > 0. Question, should cPickle and pickle be raising the same error here? UnpicklingError is defined in pickle.py and never used but cPickle.c uses it frequently. |
|
|
| msg96585 - (view) |
Author: Florent Xicluna (flox) * |
Date: 2009-12-18 21:29 |
| The patch works correctly on 2.7. It should be applied on trunk, and backported to other branches, too. ( is marked as duplicate of this one) |
|
|
| msg96593 - (view) |
Author: Florent Xicluna (flox) * |
Date: 2009-12-19 00:12 |
| I moved the test to test.pickletester, so that it can be used for all 3 tests: test_pickle test_cpickle test_xpickle (and backported a test which was only on py3k) |
|
|
| msg97361 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2010-01-07 18:05 |
| Committed in all four branches. Thank you Victor and Florent! |
|
|
| msg97495 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2010-01-10 03:04 |
| > Committed in all four branches. trunk: r77352 |
|
|