Issue 7670: _sqlite3: Block all operations on a closed Connection object (original) (raw)

Created on 2010-01-10 18:42 by vstinner, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (6)
msg97538 - (view)	Author: STINNER Victor (vstinner) *	Date: 2010-01-10 18:42
Add call to pysqlite_check_connection() on the follow methods: * create_function() * create_aggregate() * set_authorizer() * set_progress_handler() * __call__() Eg. fix the following segfault: c = Connection("test") c.close() c.set_authorizer(func) The patch includes unit tests to test all methods on a closed connection. sqlite3 already raises an error for some operations on a closed socket (eg. connection.commit()), but not on all operations.
msg100456 - (view)	Author: Gerhard Häring (ghaering) *	Date: 2010-03-05 09:23
Applied in trunk. Thanks!
msg100486 - (view)	Author: Gerhard Häring (ghaering) *	Date: 2010-03-05 15:56
Now also fixed in 2.6 and 3.1 maintenance branches.
msg100487 - (view)	Author: STINNER Victor (vstinner) *	Date: 2010-03-05 16:01
Commit numbers: r78688 (trunk), r78698 (py3k), r78699 (2.6), r78700 (3.1). 2.6 branch is froze because 2.6.5RC1 was released and 2.6.5 final is planned for next week. Ask barry if you should revert your commit or not r78699.
msg100490 - (view)	Author: Gerhard Häring (ghaering) *	Date: 2010-03-05 16:27
As requested per Barry, marking this as release blocker for 2.6.
msg100604 - (view)	Author: Barry A. Warsaw (barry) *	Date: 2010-03-07 20:39
I'm going to let this one stay for 2.6.5 since we need another rc anyway. Thanks for the fix!