Issue 7852: [PATCH] Drop "Computer" from "Apple Computer" in plistlib (original) (raw)

Issue7852

Created on 2010-02-04 09:02 by wangchun, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
plistlib.diff wangchun,2010-02-04 09:02
Messages (8)
msg98815 - (view) Author: Wang Chun (wangchun) Date: 2010-02-04 09:02
Apple's official utilities had been dropped the word "Computer". We should follow them. imac:~$ cat test.py __import__('plistlib').writePlist({}, 'test.plist') imac:~$ python test.py imac:~$ cat test.py __import__('plistlib').writePlist({}, 'test.plist') imac:~$ python test.py imac:~$ cat test.plist imac:~$ plutil -convert xml1 test.plist imac:~$ cat test.plist imac:~$
msg98893 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2010-02-05 18:28
I did a quick search and couldn't find any reference about this change, the examples in the apple doc still use 'Apple Computer'. Do you have any reference that says that the correct doctype (now) uses only 'Apple'?
msg98905 - (view) Author: Zvezdan Petkovic (zvezdan) * Date: 2010-02-05 20:30
How about this example from Mac OS X Reference Library "Property List Programming Guide": http://developer.apple.com/mac/library/documentation/Cocoa/Conceptual/PropertyLists/QuickStartPlist/QuickStartPlist.html Perhaps the fact that Apple officially changed the name from "Apple Computer" to "Apple" back in 2007 also helps: http://www.macworld.com/article/54770/2007/01/applename.html This one had a short URL, you can search Google for "apple computer changes name" for more (Forbes, Information Week, etc.) Do you have a reference where Apple docs written after 2007 use "Apple Computer"?
msg98907 - (view) Author: Zvezdan Petkovic (zvezdan) * Date: 2010-02-05 20:44
Also, on a Mac computer: - start Xcode 3.2.1 and select Help->Developer Documentation - type in the search box in the top right corner "property list" - the second hit is "Property List Programming Guide"; click on it - the second page gives the same example as the URL I put in - it uses DOCTYPE with /Apple/ only
msg98916 - (view) Author: Wang Chun (wangchun) Date: 2010-02-05 22:34
plutil is a command shipped with every Mac. See the example in my original post.
msg103759 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2010-04-20 21:01
I agree that the DTD should be changed. Fixed in r80279 (trunk) and r80280 (3.2). I won't backport to 2.6 and 3.1 because this is a mostly cosmetic issue and I do not want to risk breaking existing scripts.
msg103783 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-20 22:20
r80279 and r80280 caused many buildbot to fail: i386 Ubuntu 3.x AMD64 Ubuntu trunk AMD64 Ubuntu wide trunk x86 Ubuntu trunk x86 XP-4 trunk x86 XP-5 trunk ====================================================================== FAIL: test_appleformatting (test.test_plistlib.TestPlistlib) ---------------------------------------------------------------------- Traceback (most recent call last): File "/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/test/test_plistlib.py", line 142, in test_appleformatting "generated data was not identical to Apple's output") AssertionError: generated data was not identical to Apple's output ----------------------------------------------------------------------
msg104498 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2010-04-29 13:00
test failures have been fixed a while back.
History
Date User Action Args
2022-04-11 14:56:57 admin set github: 52100
2010-04-29 13:00:41 ronaldoussoren set status: open -> closedresolution: fixedmessages: +
2010-04-20 22:20:32 vstinner set status: closed -> opennosy: + vstinnermessages: + resolution: fixed -> (no value)
2010-04-20 21:01:52 ronaldoussoren set status: open -> closedversions: + Python 3.2messages: + resolution: fixedstage: patch review -> resolved
2010-02-09 09:05:10 ronaldoussoren set assignee: ronaldoussoren
2010-02-05 22:34:55 wangchun set messages: +
2010-02-05 21:24:55 ezio.melotti set nosy: + ronaldoussoren
2010-02-05 20:44:31 zvezdan set messages: +
2010-02-05 20:30:45 zvezdan set nosy: + zvezdanmessages: +
2010-02-05 18:28:52 ezio.melotti set priority: lownosy: + ezio.melottimessages: + stage: patch review
2010-02-04 09:02:08 wangchun create