Issue 7868: add a loggerClass attribute to Manager (original) (raw)

Created on 2010-02-06 22:06 by georg.brandl, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
logging.diff georg.brandl,2010-02-06 22:06 patch v1
Messages (7)
msg98964 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-02-06 22:06
This patch adds a loggerClass attribute to logging's Manager, and a setLoggerClass() function to set it. If no loggerClass is set, the global _loggerClass is used. This is for maximum backwards compatibility. There are no doc updates as the Manager is not documented.
msg98965 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-02-06 22:09
Hello I know the internal style (or lack thereof :) of logging forces you to use unReadableNames, but could the ocde use “cls” instead of “class”, as per PEP 8? Kind regards
msg98966 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-02-06 22:10
s/ocde/code/
msg98968 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-02-06 22:13
You mean, instead of "klass"? It is used in the other setLoggerClass(), and therefore consistent.
msg98969 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-02-06 22:15
I meant “klass”, right. My fingers are trained not to write it, it seems. Ok, it’s already used elsewhere in the module. Too bad. Kind regards
msg98976 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2010-02-07 01:38
Patch applied to trunk (r78055).
msg98984 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-02-07 09:02
Thanks!
History
Date User Action Args
2022-04-11 14:56:57 admin set github: 52116
2010-02-07 09:02:08 georg.brandl set keywords:patch, patch, easymessages: +
2010-02-07 01:38:13 vinay.sajip set status: open -> closedkeywords:patch, patch, easyresolution: fixedmessages: +
2010-02-06 22:15:24 eric.araujo set messages: +
2010-02-06 22:13:22 georg.brandl set keywords:patch, patch, easymessages: +
2010-02-06 22:10:19 eric.araujo set messages: +
2010-02-06 22:09:57 eric.araujo set nosy: + eric.araujomessages: +
2010-02-06 22:06:31 georg.brandl create