Issue 8248: Add test cases for bool (original) (raw)

Issue8248

Created on 2010-03-28 03:03 by gnofi, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_bool.v2.patch gnofi,2010-03-28 03:03 2.x trunk patch
test_bool.v3.patch gnofi,2010-03-28 03:04 3.x trunk patch
test_bool.v2.patch gnofi,2010-03-29 01:05 Updated 2.x trunk patch w/ test_bool, decimal, index
test_bool.v3.patch gnofi,2010-03-29 01:06 Updated 3.x branch patch w/ test_bool, decimal, index
Messages (4)
msg101853 - (view) Author: Gregory Nofi (gnofi) Date: 2010-03-28 03:03
These patches add these new test cases to test_bool.py. Python 2+3: - Conversion to float - Conversion to Decimal - Calling bool() of built-in types Python 2 only: - __index__() - Conversion to long - sprintf formatting NOTE: I'm currently helping Dino Viehland port IronPython tests into CPython. This is the first of that series.
msg101877 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-03-28 22:55
Decimal tests should probably be in test_decimal, not test_bool. Also, I'm not sure why the __index__ and format tests aren't in the py3k patch.
msg101883 - (view) Author: Gregory Nofi (gnofi) Date: 2010-03-29 01:05
Indeed, the Decimal test is better off in test_decimal.DecimalExplicitConstructionTest so I moved it there. I forgot to include the index test for the py3k patch. That's in the updated patch, too. There is already a format test in the py3k branch.
msg101952 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-03-30 19:00
Committed in r79502, r79504 (trunk) and r79503 (py3k). Thank you!
History
Date User Action Args
2022-04-11 14:56:59 admin set github: 52495
2010-03-30 19:01:00 pitrou set status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2010-03-29 01:06:53 gnofi set files: + test_bool.v3.patch
2010-03-29 01:05:28 gnofi set files: + test_bool.v2.patchmessages: +
2010-03-28 22:55:49 pitrou set nosy: + pitroumessages: +
2010-03-28 20:20:44 ezio.melotti set priority: normalnosy: + ezio.melottistage: patch review
2010-03-28 03:04:37 gnofi set files: + test_bool.v3.patch
2010-03-28 03:03:11 gnofi create