Issue 8363: Lots of duplicate code between test_classify_oldstyle and test_classify_newstyle in test_inspect.py (original) (raw)

Issue8363

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/52610

classification

process

Created on 2010-04-10 13:13 by exarkun, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (5)
msg102776 - (view)	Author: Jean-Paul Calderone (exarkun) *	Date: 2010-04-10 13:13
There are two tests for the way inspect.classify_class_attrs handles various sorts of attributes. The tests are identical, except one uses a classic class and one a new-style class. The tests sources have actually begun to diverge, but so far only in whitespace. This code will be easier to maintain (not to mention shorter) if there is just one copy of the actual test parts.
msg102784 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2010-04-10 16:07
I think the patch is ok except for that docstrings should start on the same line as the triple quote.
msg102785 - (view)	Author: Jean-Paul Calderone (exarkun) *	Date: 2010-04-10 16:12
Okay. I shouldn't commit until after trunk is unfrozen though, right?
msg102786 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2010-04-10 16:18
2010/4/10 Jean-Paul Calderone <report@bugs.python.org>: > > Jean-Paul Calderone <exarkun@divmod.com> added the comment: > > Okay. > > I shouldn't commit until after trunk is unfrozen though, right? Correct.
msg102791 - (view)	Author: Jean-Paul Calderone (exarkun) *	Date: 2010-04-10 20:03
Committed in r79935