| msg103411 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2010-04-17 17:26 |
| http://www.python.org/dev/buildbot/builders/sparc Debian 3.x/builds/62/steps/test/logs/stdio test_curses [?1049h[1;24r(B[m[4l[?7h[H[2J[?5h[?5l[?12l[?25habc[39;49m[?1000h[?1000l[39;49m(B[m[24;1H[?1049l [?1l>test test_curses crashed -- <class '_curses.error'>: getmouse() returned ERR Re-running test test_curses in verbose mode [?1049h[1;24r[?12l[?25h[39;49m(B[m[4l[?7h[?1000h[H[2J[?5h[?5labc[?1000h[?1000l[39;49m(B[m[24;1H[?1049l [?1l>test test_curses crashed -- <class '_curses.error'>: getmouse() returned ERR Traceback (most recent call last): File "./Lib/test/regrtest.py", line 905, in runtest_inner File "/home/pybot/buildarea-sid/3.x.klose-debian-sparc/build/Lib/test/test_curses.py", line 291, in test_main main(stdscr) File "/home/pybot/buildarea-sid/3.x.klose-debian-sparc/build/Lib/test/test_curses.py", line 275, in main module_funcs(stdscr) File "/home/pybot/buildarea-sid/3.x.klose-debian-sparc/build/Lib/test/test_curses.py", line 228, in module_funcs m = curses.getmouse() _curses.error: getmouse() returned ERR |
|
|
| msg103415 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2010-04-17 17:50 |
| Other example: http://www.python.org/dev/buildbot/builders/alpha Debian 3.x/builds/63/steps/test/logs/stdio test_curses [?1049h[1;24r(B[m[4l[?7h[H[2J[?5h[?5l[?12l[?25habc[39;49m[?1000h[?1000l[39;49m(B[m[24;1H[?1049l [?1l>test test_curses crashed -- <class '_curses.error'>: getmouse() returned ERR Re-running test test_curses in verbose mode [?1049h[1;24r[?12l[?25h[39;49m(B[m[4l[?7h[?1000h[H[2J[?5h[?5labc[?1000h[?1000l[39;49m(B[m[24;1H[?1049l [?1l>test test_curses crashed -- <class '_curses.error'>: getmouse() returned ERR Traceback (most recent call last): File "./Lib/test/regrtest.py", line 905, in runtest_inner File "/home/pybot/buildarea-sid/3.x.klose-debian-sparc/build/Lib/test/test_curses.py", line 291, in test_main main(stdscr) File "/home/pybot/buildarea-sid/3.x.klose-debian-sparc/build/Lib/test/test_curses.py", line 275, in main module_funcs(stdscr) File "/home/pybot/buildarea-sid/3.x.klose-debian-sparc/build/Lib/test/test_curses.py", line 228, in module_funcs m = curses.getmouse() _curses.error: getmouse() returned ERR |
|
|
| msg110885 - (view) |
Author: Stefan Krah (skrah) * |
Date: 2010-07-20 11:07 |
| How about skipping the tests until someone can figure out what's going on? The patch is tested on: http://www.python.org/dev/buildbot/builders/i386 Ubuntu 3.x/builds/1643 |
|
|
| msg112679 - (view) |
Author: Barry A. Warsaw (barry) * |
Date: 2010-08-03 20:59 |
| This also affects 2.6 but I've only been able to verify it on Debian squeeze and Ubuntu maverick, both of which are unreleased. On Ubuntu lucid (stable), this error does not occur. I'm testing Debian stable now... |
|
|
| msg112689 - (view) |
Author: Barry A. Warsaw (barry) * |
Date: 2010-08-03 21:28 |
| Confirmed on Ubuntu: Lucid, libncurses5 5.7+20090803-2ubuntu3 passes Maverick, libncurses5 5.7+20100626-0ubuntu1 fails |
|
|
| msg112709 - (view) |
Author: Barry A. Warsaw (barry) * |
Date: 2010-08-03 22:23 |
| Confirmed on Debian squeeze, ncurses 5.7+20100313-2 failed lenny, ncurses 5.7+20081213-1 succeeds So clearly something about the curses module is not compatible with the newer versions of ncurses. |
|
|
| msg113167 - (view) |
Author: Mark Dickinson (mark.dickinson) * |
Date: 2010-08-07 11:23 |
| I'm a bit surprised that the test *passes* at all, anywhere. The man page for getmouse says: """This function will return OK if a mouse event is actually visible in the given window, ERR otherwise.""" So if no mouse event occurs (which is presumably the usual case when test_curses is running) then I'd *expect* getmouse to return ERR. +1 on just disabling these tests for now. |
|
|
| msg113168 - (view) |
Author: Mark Dickinson (mark.dickinson) * |
Date: 2010-08-07 11:42 |
| [Barry] > So clearly something about the curses module is not compatible with the newer versions of ncurses. Yep. Here's a NEWS entry from the Ubuntu ncurses source: 20100102 + minor improvement to tic's checking of similar SGR's to allow for the most common case of SGR 0. + modify getmouse() to act as its documentation implied, returning on each call the preceding event until none are left. When no more events remain, it will return ERR. |
|
|
| msg113171 - (view) |
Author: Mark Dickinson (mark.dickinson) * |
Date: 2010-08-07 12:30 |
| Here's a patch that simply reverses the getmouse and ungetmouse calls in the test, ensuring that getmouse actually has something to get. This fixes the test_curses failure for me on Ubuntu 10.10, and doesn't seem to introduce new failures where test_curses was previously working (on OS X 10.6.4, for example). Barry, do you want me to apply this to 2.6.6, to give us another green buildbot or two? Or is it not worth it? |
|
|
| msg113172 - (view) |
Author: Mark Dickinson (mark.dickinson) * |
Date: 2010-08-07 12:34 |
| Patch applied to py3k in r83780. I'll watch the py3k buildbots to see how they do. |
|
|
| msg113706 - (view) |
Author: Barry A. Warsaw (barry) * |
Date: 2010-08-12 21:17 |
| I'm putting this one in the same category as bug 7467. I think these two, plus the patches which were applied to release26-maint after rc1 (without approval ;) will require an rc2. If that can be worked out schedule-wise, I'll allow these patches to be applied. Stay tuned. |
|
|
| msg113716 - (view) |
Author: Barry A. Warsaw (barry) * |
Date: 2010-08-12 22:50 |
| Since the patch only changes a test, and it looks innocent enough (i.e. no possibility of regression), and it only changes a test that is run with -u all, I will allow this for 2.6.6. Mark, please apply your test_curses_getmouse.patch. You can then close this issue and/or reduce the priority. Don't forget to add a NEWS file entry. |
|
|
| msg113749 - (view) |
Author: Mark Dickinson (mark.dickinson) * |
Date: 2010-08-13 08:00 |
| Fixed in 2.6 in r83970 (3.1 and 2.7 were fixed in revisions r83781, r83782). |
|
|