Issue 8445: buildbot: test_ttk_guionly failures (test_traversal, test_tab_identifiers, test_identify, test_heading_callback) (original) (raw)

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: db3l, donmez, flox, gpolo, ixokai, janssen, ned.deily, pitrou, ronaldoussoren, vstinner
Priority: normal Keywords: buildbot, patch

Created on 2010-04-18 21:29 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue8445.diff gpolo,2010-09-26 04:17 review
ttk3k.patch pitrou,2010-09-26 12:44 review
Messages (19)
msg103534 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-18 21:29
http://www.python.org/dev/buildbot/builders/x86 Tiger trunk/builds/15/steps/test/logs/stdio test test_ttk_guionly failed -- multiple errors occurred; run in verbose mode for details Re-running test 'test_ttk_guionly' in verbose mode test_horizontal_range (test_ttk.test_extensions.LabeledScaleTest) ... ok test_initialization (test_ttk.test_extensions.LabeledScaleTest) ... ok test_resize (test_ttk.test_extensions.LabeledScaleTest) ... ok test_variable_change (test_ttk.test_extensions.LabeledScaleTest) ... ok test_widget_destroy (test_ttk.test_extensions.LabeledScaleTest) ... ok test_initialization (test_ttk.test_extensions.OptionMenuTest) ... ok test_menu (test_ttk.test_extensions.OptionMenuTest) ... ok test_widget_destroy (test_ttk.test_extensions.OptionMenuTest) ... ok test_configure (test_ttk.test_style.StyleTest) ... ok test_layout (test_ttk.test_style.StyleTest) ... ok test_lookup (test_ttk.test_style.StyleTest) ... ok test_map (test_ttk.test_style.StyleTest) ... ok test_theme_use (test_ttk.test_style.StyleTest) ... ok test_identify (test_ttk.test_widgets.WidgetTest) ... FAIL test_widget_state (test_ttk.test_widgets.WidgetTest) ... ok test_invoke (test_ttk.test_widgets.ButtonTest) ... ok test_invoke (test_ttk.test_widgets.CheckbuttonTest) ... ok test_invoke (test_ttk.test_widgets.RadiobuttonTest) ... ok test_postcommand (test_ttk.test_widgets.ComboboxTest) ... ok test_values (test_ttk.test_widgets.ComboboxTest) ... ok test_virtual_event (test_ttk.test_widgets.ComboboxTest) ... ok test_bbox (test_ttk.test_widgets.EntryTest) ... ok test_identify (test_ttk.test_widgets.EntryTest) ... ok test_revalidation (test_ttk.test_widgets.EntryTest) ... ok test_validation (test_ttk.test_widgets.EntryTest) ... ok test_validation_options (test_ttk.test_widgets.EntryTest) ... ok test_add (test_ttk.test_widgets.PanedwindowTest) ... ok test_forget (test_ttk.test_widgets.PanedwindowTest) ... ok test_insert (test_ttk.test_widgets.PanedwindowTest) ... ok test_pane (test_ttk.test_widgets.PanedwindowTest) ... ok test_sashpos (test_ttk.test_widgets.PanedwindowTest) ... ok test_custom_event (test_ttk.test_widgets.ScaleTest) ... ok test_get (test_ttk.test_widgets.ScaleTest) ... ok test_set (test_ttk.test_widgets.ScaleTest) ... ok test_add_and_hidden (test_ttk.test_widgets.NotebookTest) ... ok test_forget (test_ttk.test_widgets.NotebookTest) ... ok test_index (test_ttk.test_widgets.NotebookTest) ... ok test_insert (test_ttk.test_widgets.NotebookTest) ... ok test_select (test_ttk.test_widgets.NotebookTest) ... ok test_tab (test_ttk.test_widgets.NotebookTest) ... ok test_tab_identifiers (test_ttk.test_widgets.NotebookTest) ... ERROR test_tabs (test_ttk.test_widgets.NotebookTest) ... ok test_traversal (test_ttk.test_widgets.NotebookTest) ... FAIL test_bbox (test_ttk.test_widgets.TreeviewTest) ... ok test_children (test_ttk.test_widgets.TreeviewTest) ... ok test_column (test_ttk.test_widgets.TreeviewTest) ... ok test_delete (test_ttk.test_widgets.TreeviewTest) ... ok test_detach_reattach (test_ttk.test_widgets.TreeviewTest) ... ok test_exists (test_ttk.test_widgets.TreeviewTest) ... ok test_focus (test_ttk.test_widgets.TreeviewTest) ... ok test_heading (test_ttk.test_widgets.TreeviewTest) ... ok test_heading_callback (test_ttk.test_widgets.TreeviewTest) ... FAIL test_index (test_ttk.test_widgets.TreeviewTest) ... ok test_insert_item (test_ttk.test_widgets.TreeviewTest) ... ok test_set (test_ttk.test_widgets.TreeviewTest) ... ok test_tag_bind (test_ttk.test_widgets.TreeviewTest) ... ok test_tag_configure (test_ttk.test_widgets.TreeviewTest) ... ok ====================================================================== ERROR: test_tab_identifiers (test_ttk.test_widgets.NotebookTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/test/test_ttk/test_widgets.py", line 560, in test_tab_identifiers self.assertEqual(self.nb.tab('@5,5'), self.nb.tab('current')) File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/ttk.py", line 922, in tab return _val_or_dict(kw, self.tk.call, self._w, "tab", tab_id) File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/ttk.py", line 318, in _val_or_dict res = func(*(args + options)) TclError: tab '@5,5' not found ====================================================================== FAIL: test_identify (test_ttk.test_widgets.WidgetTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/test/test_ttk/test_widgets.py", line 27, in test_identify self.assertEqual(self.widget.identify(5, 5), "label") AssertionError: 'Button.button' != 'label' ====================================================================== FAIL: test_traversal (test_ttk.test_widgets.NotebookTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/test/test_ttk/test_widgets.py", line 721, in test_traversal self.assertEqual(self.nb.select(), str(self.child1)) AssertionError: '.33941048' != '.33942584' ====================================================================== FAIL: test_heading_callback (test_ttk.test_widgets.TreeviewTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/test/test_ttk/test_widgets.py", line 941, in test_heading_callback self.fail("The command associated to the treeview heading wasn't " AssertionError: The command associated to the treeview heading wasn't invoked. ---------------------------------------------------------------------- Ran 57 tests in 0.361s
msg103538 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-18 22:17
http://www.python.org/dev/buildbot/builders/x86 FreeBSD 3.1/builds/149/steps/test/logs/stdio ====================================================================== FAIL: test_traversal (tkinter.test.test_ttk.test_widgets.NotebookTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/home/db3l/buildarea/3.1.bolen-freebsd/build/Lib/tkinter/test/test_ttk/test_widgets.py", line 708, in test_traversal self.assertEqual(self.nb.select(), str(self.child2)) AssertionError: '.219316556' != '.219317508' ---------------------------------------------------------------------- Ran 57 tests in 13.798s FAILED (failures=1) test test_ttk_guionly failed -- Traceback (most recent call last): File "/usr/home/db3l/buildarea/3.1.bolen-freebsd/build/Lib/tkinter/test/test_ttk/test_widgets.py", line 708, in test_traversal self.assertEqual(self.nb.select(), str(self.child2)) AssertionError: '.219316556' != '.219317508'
msg116213 - (view) Author: Ismail Donmez (donmez) * Date: 2010-09-12 16:25
Also reproduced on Snow Leopard.
msg116527 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2010-09-16 11:58
Unassigning because the issue affects more than just OSX and I'm not a Tkinter expert.
msg117399 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2010-09-26 04:17
Hi there, I believe I've fixed most of these errors. But I couldn't replicate the last error on the first message, so I guessed what could be the problem. Could you try the patch and see how it works for you ? (Thanks for the nosy addition, I rarely check for bugs as you may know).
msg117406 - (view) Author: Ismail Donmez (donmez) * Date: 2010-09-26 08:44
With Guilherme's patch; We are down to 1 error but thats a new errror; test test_ttk_guionly failed -- Traceback (most recent call last): File "/Users/cartman/Sources/py3k/Lib/tkinter/test/test_ttk/test_widgets.py", line 28, in test_identify self.widget.winfo_height() / 2), "label") File "/Users/cartman/Sources/py3k/Lib/tkinter/ttk.py", line 568, in identify return self.tk.call(self._w, "identify", x, y) _tkinter.TclError: expected integer but got "30.5"
msg117411 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2010-09-26 12:12
> We are down to 1 error but thats a new errror; > > > test test_ttk_guionly failed -- Traceback (most recent call last): >  File "/Users/cartman/Sources/py3k/Lib/tkinter/test/test_ttk/test_widgets.py", line 28, in test_identify >    self.widget.winfo_height() / 2), "label") >  File "/Users/cartman/Sources/py3k/Lib/tkinter/ttk.py", line 568, in identify >    return self.tk.call(self._w, "identify", x, y) > _tkinter.TclError: expected integer but got "30.5" > Just convert to integer the results from winfo and you should be fine.
msg117412 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2010-09-26 12:17
You should convert the whole expressions actually, but that is because the patch wasn't done for py3k.
msg117415 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-09-26 12:44
Here is Guilherme's patch converted for py3k.
msg117421 - (view) Author: Ismail Donmez (donmez) * Date: 2010-09-26 16:30
Patch fixes the problem for me, please apply. Thanks!
msg117422 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-09-26 16:37
Committed in r85018, will watch the buildbots.
msg117423 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-09-26 16:50
There's an issue remaining on the buildbots: ====================================================================== FAIL: test_heading_callback (tkinter.test.test_ttk.test_widgets.TreeviewTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/tkinter/test/test_ttk/test_widgets.py", line 945, in test_heading_callback self.fail("The command associated to the treeview heading wasn't " AssertionError: The command associated to the treeview heading wasn't invoked.
msg117424 - (view) Author: Ismail Donmez (donmez) * Date: 2010-09-26 16:50
Works for me on Snow Leopard for the record.
msg117994 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2010-10-05 07:45
The test_heading_callback failure appears to be another Tk 8.4 vs Tk 8.5 problem. Datapoints: the test fails using the Apple-supplied Tk 8.4 in OS X 10.6 and with a recent ActiveState Aqua Tk 8.4 on OS X 10.5; the test succeeds with the Apple-supplied Tk 8.5 in OS X 10.6.
msg118239 - (view) Author: Stephen Hansen (ixokai) (Python triager) Date: 2010-10-09 00:11
I'm still getting this error on the release27-maint branch on my Snow Leopard slave, and the .diff fixes it: will this fix be backported? I tested .diff and it applies cleanly, and fixes the issue.
msg118240 - (view) Author: Stephen Hansen (ixokai) (Python triager) Date: 2010-10-09 00:41
BTW, release31-maint appears to have the same issue, its fouling up that build on my slave too. I tried applying the ttk3k.patch but it didn't apply cleanly, and I'm completely ignorant of TK so can't really figure out what's different between the 3.1->3.2 version to try to adjust the fix and test it out. Then again I'm not sure if there's still going to be test-fixes applied to 3.1. So its possible you can just ignore this comment :)
msg118262 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-10-09 10:28
I backported the patch to 2.7 (r85335) and to 3.1 (r85338). Hopefully things will be ok now.
msg118273 - (view) Author: Stephen Hansen (ixokai) (Python triager) Date: 2010-10-09 14:34
For the record, everything (2.7, 3.1, and 3.x) runs this test successfully now. :)
msg133615 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2011-04-12 23:02
I don't understand why this issue is still open, so let's close it.
History
Date User Action Args
2022-04-11 14:57:00 admin set github: 52692
2011-04-12 23:02:40 vstinner set status: open -> closedmessages: +
2010-10-09 14:34:40 ixokai set messages: +
2010-10-09 10:28:46 pitrou set messages: +
2010-10-09 00:41:23 ixokai set messages: +
2010-10-09 00:11:47 ixokai set nosy: + ixokaimessages: +
2010-10-05 07:45:09 ned.deily set nosy: + ned.deilymessages: +
2010-09-26 16:50:57 donmez set messages: +
2010-09-26 16:50:03 pitrou set status: pending -> openmessages: +
2010-09-26 16:37:21 pitrou set status: open -> pendingresolution: fixedmessages: + stage: needs patch -> resolved
2010-09-26 16:30:18 donmez set messages: +
2010-09-26 12:44:41 pitrou set files: + ttk3k.patchnosy: + pitroumessages: +
2010-09-26 12:17:26 gpolo set messages: +
2010-09-26 12:12:49 gpolo set messages: +
2010-09-26 08:44:16 donmez set messages: +
2010-09-26 04:17:48 gpolo set files: + issue8445.diffkeywords: + patchmessages: +
2010-09-25 16:44:16 pitrou set nosy: + gpolo
2010-09-25 11:12:35 pitrou set nosy: + db3l
2010-09-16 18:46:06 ned.deily link issue8921 superseder
2010-09-16 11:58:52 ronaldoussoren set assignee: ronaldoussoren -> messages: +
2010-09-12 17:20:59 pitrou set nosy: + janssen
2010-09-12 16:25:46 donmez set messages: +
2010-09-11 15:24:37 flox set nosy: + donmez, ronaldoussoren, floxassignee: ronaldoussorencomponents: + macOStype: behaviorstage: needs patch
2010-09-11 15:20:35 flox link issue9833 superseder
2010-04-18 23:12:35 vstinner set title: buildbot: test_ttk_guionly failures -> buildbot: test_ttk_guionly failures (test_traversal, test_tab_identifiers, test_identify, test_heading_callback)
2010-04-18 22:47:29 vstinner set components: + Tests, Tkinter
2010-04-18 22:19:23 vstinner set versions: + Python 3.1, Python 3.2
2010-04-18 22:17:49 vstinner set messages: +
2010-04-18 21:29:11 vstinner create