Issue 8476: build-installer fix for setIcon when no script path specified (original) (raw)

Issue8476

Created on 2010-04-20 22:57 by db3l, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (3)
msg103791 - (view)	Author: David Bolen (db3l) *	Date: 2010-04-20 22:57
The attached suggested patch fixes a small bug where if you execute the build-installer script without an explicit path (e.g., "python build-installer.py") the setIcon compilation will fail since dirname(__file__) is an empty string, so it ends up looking for files beneath "/". It also normalizes the function slightly, since part of the previous code explicitly used dirname(__file__) whereas part of the code just assumed the output directory was relative to the current directory.
msg104500 - (view)	Author: Ronald Oussoren (ronaldoussoren) *	Date: 2010-04-29 13:02
The patch looks good, I will apply it over the weekend. Thanks for looking into this.
msg104642 - (view)	Author: Ronald Oussoren (ronaldoussoren) *	Date: 2010-04-30 15:01
Committed in r80653 (trunk), r80654 (2.6), r80655 (3.2) and r80656 (3.1)