Issue 8602: documentation of bz2 module mildly erroneous (original) (raw)

Created on 2010-05-03 07:03 by Matt.Wartell, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue-8602.diff Matt.Wartell,2010-05-08 01:11 context diff for 2.6.5 documentation tree
Messages (6)
msg104818 - (view) Author: Matt Wartell (Matt.Wartell) Date: 2010-05-03 07:03
This is related to http://bugs.python.org/issue8601 "bz2.BZ2File should support "with" protocol per PEP 343" The documentation at http://docs.python.org/library/bz2.html states: "This module provides a comprehensive interface for the bz2 compression library. It implements a complete file interface,..." although bz2.BZ2File does not support the __enter__ and __exit__ methods so arguably doesn't implement the "complete file interface". If is declined then the documentation should probably note this exception.
msg105237 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-05-07 21:52
Now that #8601 is closed, would you mind providing a doc patch explaining the lack of context manager protocol support and its reason?
msg105248 - (view) Author: Matt Wartell (Matt.Wartell) Date: 2010-05-08 01:11
Per request, I have attached a context diff for both bz2.txt and 3.0.txt suitable for http://docs.python.org/library/bz2.html and http://docs.python.org/release/3.0.1/whatsnew/3.0.html respectively. The modification in bz2.txt may border on redundant and overly verbose and should be reviewed for style consistency. I have sanity-checked the modified files with sphinx-build html which generates clean, consistent markup.
msg107756 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-06-13 21:59
I’d remove the lines “Specifically it does not define the :meth:`__enter__` and :meth:`__exit__` methods required by the :keyword:`with` statement”, since they add unnecessary length to a simple note. Please provide one patch per branch, and diff from the top level of the checkout (see http://www.python.org/dev/patches/). Thanks!
msg107757 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-06-13 22:01
Also, don’t bother with 3.0: It is not supported by python-dev anymore. Make documentation patches for py3k and trunk, and they’ll be backported to the stable branches 3.1 and 2.6.
msg112337 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-08-01 14:52
Now present in all maintained branches.
History
Date User Action Args
2022-04-11 14:57:00 admin set github: 52848
2010-08-01 14:52:11 georg.brandl set status: open -> closednosy: + georg.brandlmessages: + resolution: out of date
2010-06-13 22:01:16 eric.araujo set messages: +
2010-06-13 21:59:59 eric.araujo set status: pending -> openmessages: +
2010-05-08 01:11:43 Matt.Wartell set status: open -> pendingfiles: + issue-8602.diffmessages: + keywords: + patch
2010-05-07 21:52:25 eric.araujo set nosy: + eric.araujomessages: +
2010-05-03 07:03:52 Matt.Wartell create