Issue 8641: IDLE 3 doesn't highlights b"", but u"" (original) (raw)

Created on 2010-05-07 06:16 by puzzlet, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
IDLE_py3k_string_highlighting.diff taleinat,2010-06-06 06:12 proposed patch review
Messages (8)
msg105184 - (view) Author: Puzzlet Chung (puzzlet) Date: 2010-05-07 06:16
IDLE 3.1.2 doesn't highlight b"" syntax, instead highlights u"". Tested with IDLE (x86) 3.1.2 and Windows XP SP2.
msg105244 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2010-05-07 23:17
u'whatever' is not valid syntax for 3.x. In any case, with IDLE on my WinXP 3.1.2 system, all string literals are green, with or without a leading b. If you want this to stay open, cut and paste the opening header like Python 3.1.2 (r312:79149, Mar 21 2010, 00:41:52) [MSC v.1500 32 bit (Intel)] on win32 and some actual code and specify what you see and what you think is wrong.
msg105254 - (view) Author: Puzzlet Chung (puzzlet) Date: 2010-05-08 03:06
> In any case, with IDLE on my WinXP 3.1.2 system, all string literals are green, with or without a leading b. The letter b should also be green, while it shows the letter u from u'string' in green, which it shouldn't as it's not valid anymore. Tested in IDLE with following version of Python: Python 3.1.2 (r312:79149, Mar 20 2010, 22:55:39) [MSC v.1500 64 bit (AMD64)] on win32
msg107185 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2010-06-06 06:12
Attaching patch against current py3k branch. I simply replaced the occurrences of [rRuU] in the relevant regexps to [rRbB].
msg107188 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2010-06-06 06:25
See also #7166.
msg148946 - (view) Author: Roger Serwy (roger.serwy) * (Python committer) Date: 2011-12-07 01:08
I applied the patch against the latest version in the repository and it works correctly.
msg148954 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-12-07 09:14
New changeset 3822c8087d70 by Ned Deily in branch '3.2': Issue #8641: Update IDLE 3 syntax coloring to recognize b".." and not u"..". http://hg.python.org/cpython/rev/3822c8087d70 New changeset e49220f4c31f by Ned Deily in branch 'default': Issue #8641: Update IDLE 3 syntax coloring to recognize b".." and not u"..". http://hg.python.org/cpython/rev/e49220f4c31f
msg148955 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2011-12-07 09:17
Thanks for the patch, Tal, and thanks for testing it, Roger. Applied to 3.2 for release in 3.2.3 and to default for 3.3.0.
History
Date User Action Args
2022-04-11 14:57:00 admin set github: 52887
2011-12-07 09:17:07 ned.deily set status: open -> closedassignee: ned.deilyversions: - Python 3.1nosy: + ned.deilymessages: + resolution: works for me -> fixedstage: resolved
2011-12-07 09:14:53 python-dev set nosy: + python-devmessages: +
2011-12-07 01:08:34 roger.serwy set versions: + Python 3.2, Python 3.3nosy: + roger.serwymessages: + type: behavior
2010-06-06 06:25:40 ezio.melotti set nosy: + lieryan, ezio.melottimessages: +
2010-06-06 06:12:40 taleinat set files: + IDLE_py3k_string_highlighting.diffnosy: + taleinatmessages: + keywords: + patch
2010-05-08 03:06:50 puzzlet set status: pending -> openmessages: +
2010-05-07 23:17:24 terry.reedy set status: open -> pendingnosy: + terry.reedymessages: + resolution: works for me
2010-05-07 06:16:33 puzzlet create