Issue 8761: PyUnicode_CompareWithASCIIString name is not mangled (UCS2, UCS4) (original) (raw)

Issue8761

Created on 2010-05-18 23:50 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
pyunicode_compareascii.patch vstinner,2010-05-18 23:50
Messages (3)
msg106015 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-05-18 23:50
In unicodeobject.h, you can see: # define PyUnicode_CompareWithASCII PyUnicodeUCS2_CompareASCII ... # define PyUnicode_CompareWithASCII PyUnicodeUCS4_CompareWithASCII ... PyAPI_FUNC(int) PyUnicode_CompareWithASCIIString( PyObject *left, const char *right ); The defines miss the String suffix :-/ Attached patch adds the suffix but I guess that it breaks backward compatibility. Is it a problem to apply this patch in Python 3.2 (but not in Python 3.1)?
msg106039 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2010-05-19 06:23
It's fine to apply to 3.2.
msg119529 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-10-24 20:38
Fixed by r85827.
History
Date User Action Args
2022-04-11 14:57:01 admin set github: 53007
2010-10-24 20:38:50 vstinner set status: open -> closedresolution: accepted -> fixedmessages: +
2010-05-19 06:23:59 loewis set resolution: acceptedmessages: + nosy: + loewis
2010-05-18 23:50:21 vstinner create