I tried to use “make patchcheck” after edits to reST files and it hung. Do you have the same behavior? I suspect reindent-rst is the culprit. I’m wondering about the reindenting; other checks in patchcheck don’t edit files, they just print warnings. On the other hand, removing trailing whitespace and reindenting is not a very good use of people’s time, so having a tool do them is good.
Just ran it without issue after doing an `svn up`. As for fix vs. not, while fixing indentations and removing trailing whitespace is nice, it isn't necessary. Both instances should be a rarity (most IDEs will make sure the situation doesn't occur), so the most important thing is detecting there is an issue for people to fix them (along with providing as much info as possible to make it easy to fix) rather than fixing it for them (if that turns out to be somewhat complicated to do).
