Issue 9318: Py3k compilation on old MSVC (original) (raw)

Created on 2010-07-21 05:49 by ocean-city, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
py3k_compile_on_old_compiler.patch ocean-city,2010-07-21 05:49
Messages (5)
msg111007 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-07-21 05:49
Hello. Attached patch is needed to compile on MSVC6. I'm appriciated if this patch is accepted.
msg113545 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-08-10 16:11
PC/pyconfig.h: no more needed. fixed in posixmodule.c Python/import.c: my patch was wrong. we should use _mkdir(const char*) on windows. there is deprecated function mkdir(const char*), but it doesn't take mode_t as parameter. so maybe it is unsafe to call with mkdir(dirpath, dirmode) on windows.
msg115983 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-09-10 06:57
Patch for import.c was checked in (#9752), so last piece is just patch for Include/pythread.h. I'll commit this near future. I believe this is not problematic.
msg116122 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-09-11 21:21
I agree.
msg116127 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-09-11 22:36
Thank you, fixed in r84724(py3k).
History
Date User Action Args
2022-04-11 14:57:04 admin set github: 53564
2010-09-11 22:36:25 ocean-city set status: open -> closedversions: - Python 3.1messages: + assignee: ocean-city -> resolution: accepted -> fixedstage: patch review -> resolved
2010-09-11 21:21:36 georg.brandl set resolution: acceptedmessages: + nosy: + georg.brandl
2010-09-10 06:57:21 ocean-city set assignee: ocean-citymessages: +
2010-08-10 16:11:08 ocean-city set messages: +
2010-07-21 13:00:37 r.david.murray set nosy: + loewis, brian.curtin
2010-07-21 05:49:05 ocean-city create