Issue 9322: Don’t fail silently if ext_modules use absolute paths (original) (raw)

Created on 2010-07-21 14:05 by indiedan, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
d1-ext-absolute-sources-9322.diff eric.araujo,2011-09-12 16:24 review
Messages (6)
msg111058 - (view) Author: Dan OD (indiedan) Date: 2010-07-21 14:05
Setting absolute paths for C source code files in setup.py breaks bdist_rpm ext_modules=[Extension('foo', [os.path.abspath('src/foo.c')])], results in bdist_rpm not including src/foo.c in the RPM, however ext_modules=[Extension('foo', ['src/foo.c'])], works just fine.
msg111062 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-07-21 14:23
Examples in the documentation only use relative paths, so in my opinion the bug here is the silent failure. Do absolute paths work for sdist or other bdists?
msg111065 - (view) Author: Dan OD (indiedan) Date: 2010-07-21 14:28
I'm still ironing out the crinkles, but this has been working for sdist build (/install) bdist_dumb unfortunately I don't have access to a Windows machine to test the other two. A non-silent warning/error would keep me happy.
msg143919 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2011-09-12 16:24
I started to work on a simple patch but it makes one of our tests fail. It uses absolute paths because it needs to change directory and check that get_outputs works.
msg348611 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-07-29 11:28
This issue is 9 years old has a patch: it's far from being "newcomer friendly", I remove the "Easy" label.
msg386282 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2021-02-03 18:10
Distutils is now deprecated (see PEP 632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils. If this issue does not relate to distutils, please remove the component and reopen it. If you believe it still requires a fix, most likely the issue should be re-reported at https://github.com/pypa/setuptools
History
Date User Action Args
2022-04-11 14:57:04 admin set github: 53568
2021-02-03 18:10:49 steve.dower set status: open -> closednosy: + steve.dowermessages: + resolution: out of datestage: needs patch -> resolved
2019-07-29 11:28:33 vstinner set keywords: - easynosy: + vstinnermessages: +
2014-06-28 14🔞22 BreamoreBoy set nosy: + dstufftcomponents: - Distutils2versions: + Python 3.4, Python 3.5, - 3rd party, Python 3.2, Python 3.3
2011-09-12 16:24:19 eric.araujo set files: + d1-ext-absolute-sources-9322.diffversions: + Python 3.3, - Python 3.1messages: + dependencies: + distutils build_ext.get_outputs returns wrong resultkeywords: + patch
2010-12-15 23:12:00 eric.araujo set keywords: + easynosy:tarek, eric.araujo, indiedan
2010-11-12 00:51:11 eric.araujo set title: bdist_rpm ext_modules absolute source path fail -> Don’t fail silently if ext_modules use absolute pathsnosy:tarek, eric.araujo, indiedanversions: + 3rd party, Python 3.1, Python 3.2assignee: tarek -> eric.araujocomponents: + Distutils2stage: needs patch
2010-07-21 14:28:11 indiedan set messages: +
2010-07-21 14:23:36 eric.araujo set nosy: + eric.araujomessages: +
2010-07-21 14:05:28 indiedan create