Issue 9927: Leak around GetFinalPathNameByHandle (Windows) (original) (raw)

Created on 2010-09-23 15:39 by ocean-city, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
py3k_fix_leak_around_GetFinalPathNameByHandle_v2.patch ocean-city,2010-12-09 10:47 review
Messages (5)
msg117197 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-09-23 15:39
I've found there are leaks around GetFinalPathNameByHandle in Modules/posixmodule.c. (Leaks when function fails) I hope attached patch will fix this.
msg117200 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-09-23 15:50
I cannot test this directly. Thank you.
msg117205 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-09-23 16:14
The tests pass here, but I haven't thoroughly reviewed the patch yet. After a quick glance it generally looks ok, although I wish we didn't have so much duplication.
msg123675 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-12-09 10:47
This is updated version. Can you test this? (I only fixed leak, deferred other fixes to future)
msg136063 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2011-05-16 02:58
I'll close this entry because #12084 contains this fix.
History
Date User Action Args
2022-04-11 14:57:06 admin set github: 54136
2011-05-16 02:58:51 ocean-city set status: open -> closedsuperseder: os.stat() on windows doesn't consider relative symlinkmessages: +
2010-12-09 10:47:53 ocean-city set files: - py3k_fix_leak_around_GetFinalPathNameByHandle.patch
2010-12-09 10:47:31 ocean-city set files: + py3k_fix_leak_around_GetFinalPathNameByHandle_v2.patchmessages: +
2010-09-23 16:14:35 brian.curtin set messages: +
2010-09-23 15:50:05 ocean-city set messages: +
2010-09-23 15:48:21 brian.curtin set nosy: + jaraco, brian.curtintype: resource usagecomponents: + Extension Modulesstage: patch review
2010-09-23 15:47:26 ocean-city set messages: -
2010-09-23 15:46:48 ocean-city set messages: +
2010-09-23 15:39:07 ocean-city create