Issue 9991: xmlrpc client ssl check faulty (original) (raw)

Created on 2010-09-29 22:15 by jniehof, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
xmlrpc_client_ssl_check.patch jniehof,2010-09-29 22:15 Patch to fix check for ssl; includes unit test review
Messages (7)
msg117667 - (view) Author: Jonathan Niehof (jniehof) Date: 2010-09-29 22:15
This has been reported before (#6494, #7987) and closed as "You need to build Python with SSL support." However, this error is raised even if ssl support is included. The SSL check in xmlrpc.client for Python 3.1 is: if not hasattr(socket, "ssl") but ssl was removed from socket and into its own class for Py3k. So one workaround, provided ssl support is available: import socket if not hasattr(socket, 'ssl') socket.ssl = None import xmlrpc.client at which point everything works fine. The attached patch fixes the bug, checking for ssl support based on the existence of http.client.HTTPSConnection, which is similar to the check in Python 2.7.
msg118393 - (view) Author: Jesse Kaukonen (gekko) Date: 2010-10-11 21:36
This problem also occurs with our service at www.renderfarm.fi with Blender. I tested the included patch, and can confirm that it works. I'm very interested in the possibility of seeing this included in the official release ASAP!
msg121182 - (view) Author: Julius Tuomisto (Julius.Tuomisto) Date: 2010-11-14 09:33
Renderfarm.fi's python based "uploader" for Blender 2.5 (GPL licensed and a part of the main distribution of Blender) is still suffering from this bug. We're hopeful that this issue would be fixed in the next versions of Python. Thank you!
msg121183 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2010-11-14 10:01
That's sad. The fix is very simple. We shall have it before 3.2 alpha4 or beta1.
msg121458 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2010-11-18 15:05
Fixed in r86514 (py3k) and r86515 (release31-maint).
msg121479 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2010-11-18 17:12
r86523(py3k) and r86524(release31-maint)
msg124127 - (view) Author: Jesse Kaukonen (gekko) Date: 2010-12-16 13:23
I tested the latest release of Python (3.1.3) with Blender and everything worked beautifully. Renderfarm.fi thanks you for fixing this!
History
Date User Action Args
2022-04-11 14:57:07 admin set github: 54200
2010-12-16 13:23:46 gekko set nosy:loewis, orsenthil, lister171254, flox, Jelly.Chen, jniehof, gekko, Julius.Tuomistomessages: +
2010-11-18 17:12:11 orsenthil set messages: +
2010-11-18 15:07:23 orsenthil set status: open -> closed
2010-11-18 15:05:06 orsenthil set assignee: orsenthilresolution: fixedmessages: + stage: resolved
2010-11-14 10:01:42 orsenthil set messages: +
2010-11-14 09:33:52 Julius.Tuomisto set nosy: + Julius.Tuomistomessages: +
2010-10-11 21:44:19 pitrou set nosy: + orsenthil
2010-10-11 21:36:54 gekko set nosy: + gekkomessages: +
2010-10-05 17:35:34 jniehof set nosy: + lister171254, Jelly.Chen
2010-09-29 22:19:34 pitrou set nosy: + loewis, flox
2010-09-29 22:15:32 jniehof create