Expose SSL contexts - Code Review (original) (raw)

Thanks for the comments.

http://codereview.appspot.com/1124044/diff/1/4 File Lib/test/test_ssl.py (right):

http://codereview.appspot.com/1124044/diff/1/4#newcode297 Lib/test/test_ssl.py:297: pass On 2010/05/16 14:19:01, jcalderone wrote:

Would this be better using assertRaises? Right now it passes even if ssl.SSLError isn't raised.

You're right, this should fail if SSLError isn't raised.

http://codereview.appspot.com/1124044/diff/1/5 File Modules/_ssl.c (right):

http://codereview.appspot.com/1124044/diff/1/5#newcode290 Modules/_ssl.c:290: #if 0 On 2010/05/16 14:19:01, jcalderone wrote:

Something left to be done here?

No, I think that error check wasn't needed. I should just remove the commented code. (furthermode, someone might want to run an SSL server with anonymous ciphers)

http://codereview.appspot.com/1124044/diff/1/5#newcode330 Modules/_ssl.c:330: } On 2010/05/16 14:19:01, jcalderone wrote:

It looks like this isn't needed anymore?

Indeed. Just a leftover from previous code.