Improve Python's handling of CFLAGS and friends - Code Review (original) (raw)

Description

http://bugs.python.org/issue9189 `../src/configure --with-pydebug && make` originally produced gcc -c -fno-strict-aliasing -g -O2 -g -O0 -Wall -Wstrict-prototypes -I. -IInclude -I../src/Include -DPy_BUILD_CORE -o Python/pythonrun.o ../src/Python/pythonrun.c After this patch, that becomes gcc -c -fno-strict-aliasing -g -O0 -Wall -Wstrict-prototypes -I. -IInclude -I../src/Include -DPy_BUILD_CORE -o Python/pythonrun.o ../src/Python/pythonrun.c For `../src/configure --with-pydebug CFLAGS=-g3 && make CFLAGS=-Werror`, we get gcc -c -fno-strict-aliasing -g -O0 -Wall -Wstrict-prototypes -g3 -I. -IInclude -I../src/Include -DPy_BUILD_CORE -o Python/pythonrun.o ../src/Python/pythonrun.c Without pydebug, we get: gcc -c -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -IInclude -I../src/Include -DPy_BUILD_CORE -o Python/pythonrun.o ../src/Python/pythonrun.c

Patch Set 1#

Patch Set 2 : + NEWS entry#

Total comments: 1

Patch Set 3 : Fix Brett's comment#

Patch Set 4 : Fix some of Marc-Andre's comments#

Total comments: 2

Messages

Total messages: 3