Python parsedate two-digit year behavior (Py3k) - Code Review (original) (raw)

I don’t know much about email, but the code itself looks good to me. I see there is only one new test; I hope this means that the old behavior is already covered and that the new code does not break compatibility. If this is the case, nice bug fix.

http://codereview.appspot.com/217107/diff/1/2 File Lib/email/_parseaddr.py (right):

http://codereview.appspot.com/217107/diff/1/2#newcode1 Lib/email/_parseaddr.py:1: # Copyright (C) 2002-2007, 2010 Python Software Foundation “2002-2010” would make more sense.

http://codereview.appspot.com/217107/diff/1/2#newcode24 Lib/email/_parseaddr.py:24: DOY_UNKNOWN = 1 Can you add a comment explaining what DOY means, unless it’s obvious for email specialists?