Review for Python issue 5094 - Code Review (original) (raw)

OLD

NEW

1 from datetime import tzinfo, timedelta, datetime

1 from datetime import tzinfo, timedelta, datetime

2

2

3 ZERO = timedelta(0)

3 ZERO = timedelta(0)

4 HOUR = timedelta(hours=1)

4 HOUR = timedelta(hours=1)

5

5

6 # A UTC class.

7

8 class UTC(tzinfo):

9 """UTC"""

10

11 def utcoffset(self, dt):

12 return ZERO

13

14 def tzname(self, dt):

15 return "UTC"

16

17 def dst(self, dt):

18 return ZERO

19

20 utc = UTC()

21

22 # A class building tzinfo objects for fixed-offset time zones.

6 # A class building tzinfo objects for fixed-offset time zones.

23 # Note that FixedOffset(0, "UTC") is a different way to build a

7 # Note that FixedOffset(0, "UTC") is a different way to build a

24 # UTC tzinfo object.

8 # UTC tzinfo object.

25

9

26 class FixedOffset(tzinfo):

10 class FixedOffset(tzinfo):

27 """Fixed offset in minutes east from UTC."""

11 """Fixed offset in minutes east from UTC."""

28

12

29 def __init__(self, offset, name):

13 def __init__(self, offset, name):

30 self.__offset = timedelta(minutes = offset)

14 self.__offset = timedelta(minutes = offset)

31 self.__name = name

15 self.__name = name

(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading...

160 # dt first.

144 # dt first.

161 if start <= dt.replace(tzinfo=None) < end:

145 if start <= dt.replace(tzinfo=None) < end:

162 return HOUR

146 return HOUR

163 else:

147 else:

164 return ZERO

148 return ZERO

165

149

166 Eastern = USTimeZone(-5, "Eastern", "EST", "EDT")

150 Eastern = USTimeZone(-5, "Eastern", "EST", "EDT")

167 Central = USTimeZone(-6, "Central", "CST", "CDT")

151 Central = USTimeZone(-6, "Central", "CST", "CDT")

168 Mountain = USTimeZone(-7, "Mountain", "MST", "MDT")

152 Mountain = USTimeZone(-7, "Mountain", "MST", "MDT")

169 Pacific = USTimeZone(-8, "Pacific", "PST", "PDT")

153 Pacific = USTimeZone(-8, "Pacific", "PST", "PDT")

OLD

NEW