email5 bytes parsing patch - Code Review (original) (raw)
Patch Set 1#
Total comments: 26
Created: 14 years, 7 months ago
Unified diffs | Side-by-side diffs | Delta from patch set | Stats (+515 lines, -78 lines) | Patch | ||||
---|---|---|---|---|---|---|---|---|
![]() |
M | Doc/library/email.rst | View | 2 chunks | +33 lines, -1 line | 0 comments | Download | |
![]() |
M | Doc/library/email.generator.rst | View | 2 chunks | +19 lines, -0 lines | 0 comments | Download | |
![]() |
M | Doc/library/email.message.rst | View | 2 chunks | +15 lines, -3 lines | 0 comments | Download | |
![]() |
M | Doc/library/email.parser.rst | View | 3 chunks | +23 lines, -4 lines | 2 comments | Download | |
![]() |
M | Lib/email/__init__.py | View | 2 chunks | +9 lines, -1 line | 0 comments | Download | |
![]() |
M | Lib/email/generator.py | View | 12 chunks | +126 lines, -43 lines | 8 comments | Download | |
![]() |
M | Lib/email/message.py | View | 6 chunks | +72 lines, -25 lines | 11 comments | Download | |
![]() |
M | Lib/email/parser.py | View | 1 chunk | +11 lines, -0 lines | 0 comments | Download | |
![]() |
M | Lib/email/test/test_email.py | View | 3 chunks | +207 lines, -1 line | 5 comments | Download |
Messages
Total messages: 4
Antoine Pitrou | This is a quick review. http://codereview.appspot.com/2362041/diff/1/Lib/email/message.py File Lib/email/message.py (right): http://codereview.appspot.com/2362041/diff/1/Lib/email/message.py#newcode29 Lib/email/message.py:29: has_surrogates = re.compile( Do ... | 14 years, 7 months ago (2010-10-03 00:28:19 UTC)#1 |
---|
barry | http://codereview.appspot.com/2362041/diff/1/Doc/library/email.parser.rst File Doc/library/email.parser.rst (right): http://codereview.appspot.com/2362041/diff/1/Doc/library/email.parser.rst#newcode81 Doc/library/email.parser.rst:81: error handler; this data will be recognized as binary ... | 14 years, 7 months ago (2010-10-04 17:34:35 UTC)#2 |
---|
r.david.murray | http://codereview.appspot.com/2362041/diff/1/Doc/library/email.parser.rst File Doc/library/email.parser.rst (right): http://codereview.appspot.com/2362041/diff/1/Doc/library/email.parser.rst#newcode81 Doc/library/email.parser.rst:81: error handler; this data will be recognized as binary ... | 14 years, 7 months ago (2010-10-06 01:20:39 UTC)#3 |
---|
| Antoine Pitrou | http://codereview.appspot.com/2362041/diff/1/Lib/email/message.py File Lib/email/message.py (right): http://codereview.appspot.com/2362041/diff/1/Lib/email/message.py#newcode30 Lib/email/message.py:30: '([^\ud800-\udbff]|\A)[\udc00-\udfff]([^\udc00-\udfff]|\Z)').search On 2010/10/06 01:20:39, r.david.murray wrote: > I have ... | 14 years, 7 months ago (2010-10-06 15:41:23 UTC)#4 | | ------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------- |