issue 9807 part 1 - Code Review (original) (raw)

http://codereview.appspot.com/2478042/diff/2001/configure.in File configure.in (right):

http://codereview.appspot.com/2478042/diff/2001/configure.in#newcode3646 configure.in:3646: # shared library name on some platforms. On 2010/10/14 23:00:57, Antoine Pitrou wrote:

Why only some platforms? Where does the list come from?

From earlier sections, IIRC. I don't think we have an official list of shared library supported platforms, so we'll just have to modify this list as platform champions come forward.

http://codereview.appspot.com/2478042/diff/2001/configure.in#newcode3649 configure.in:3649: SunOS*) On 2010/10/14 23:00:57, Antoine Pitrou wrote:

Why a separate case for SunOS? I don't see any difference.

I grabbed this from an earlier section with enabled_shared, but you're right, after modification, there's no difference so I'll roll this into one clause.

http://codereview.appspot.com/2478042/diff/2001/configure.in#newcode3653 configure.in:3653: INSTSONAME="$LDLIBRARY".$SOVERSION.${ABIFLAGS} On 2010/10/14 23:00:57, Antoine Pitrou wrote:

Please put the ABIFLAGS before the ".so.3.2".

Right, we did agree to that. It's not a simple change though because $LDLIBRARY needs to use a different variable than $VERSION. It's actually a PITA ;) and will necessitate changes on OSes I don't have access to, so informing python-dev will be required. I'll see what I can do though.