py3k lzma patch - Code Review (original) (raw)

Description

patch that adds the lzma module.

Patch Set 1#

Total comments: 7

Messages

Total messages: 5

| proyvind | | 14 years, 6 months ago (2010-10-31 15:00:01 UTC)#1 | | ------------ | | ----------------------------------------------------------- |

Martin v. Löwis http://codereview.appspot.com/2724043/diff/1/Doc/library/lzma.rst File Doc/library/lzma.rst (right): http://codereview.appspot.com/2724043/diff/1/Doc/library/lzma.rst#newcode54 Doc/library/lzma.rst:54: .. attribute:: lzma.options.check The attribute is called check, not ... 14 years, 6 months ago (2010-10-31 16:33:38 UTC)#2
proyvind On 2010/10/31 16:33:38, Martin v. Löwis wrote: > http://codereview.appspot.com/2724043/diff/1/Doc/library/lzma.rst > File Doc/library/lzma.rst (right): > > ... 14 years, 6 months ago (2010-10-31 20:46:13 UTC)#3
Martin v. Löwis >> Modules/lzmamodule.c:264: lzma_FILE *fp; >> I suggest that struct lzma_FILE is inlined here - no ... 14 years, 6 months ago (2010-10-31 21:21:28 UTC)#4
proyvind On 2010/10/31 21:21:28, Martin v. Löwis wrote: > >> Modules/lzmamodule.c:264: lzma_FILE *fp; > >> I ... 14 years, 6 months ago (2010-10-31 21:32:17 UTC)#5