(not quite finished) memoryview implementation - Code Review (original) (raw)
Patch Set 1#
Patch Set 2 : New patch after cosmetic changes suggested by Benjamin & GvR#
Patch Set 3 : Oops, right patch this time#
Patch Set 4 : Fix some small exception bugs#
Messages
Total messages: 10
| Benjamin | Looks pretty straightforward. Let GvR review though.e http://codereview.appspot.com/3004/diff/1/4 File Lib/test/test_memoryview.py (right): http://codereview.appspot.com/3004/diff/1/4#newcode11 Line 11: class ... | 16 years, 9 months ago (2008-08-19 19:59:51 UTC)#1 |
|---|
| Antoine Pitrou | http://codereview.appspot.com/3004/diff/1/4 File Lib/test/test_memoryview.py (right): http://codereview.appspot.com/3004/diff/1/4#newcode11 Line 11: class CommonMemoryTests: On 2008/08/19 19:59:52, Benjamin wrote: > ... | 16 years, 9 months ago (2008-08-19 20:12:47 UTC)#2 |
|---|
| GvR | Sorry, I can't review this. I don't know enough about the PEP 3118 implementation. :-( ... | 16 years, 9 months ago (2008-08-19 20:20:18 UTC)#3 |
|---|
| Benjamin | A few more comments. I think it's about ready to commit. http://codereview.appspot.com/3004/diff/10/31 File Objects/memoryobject.c (right): ... | 16 years, 9 months ago (2008-08-19 21:19:23 UTC)#4 |
|---|
| Antoine Pitrou | http://codereview.appspot.com/3004/diff/10/31 File Objects/memoryobject.c (right): http://codereview.appspot.com/3004/diff/10/31#newcode606 Line 606: PyErr_SetNone(PyExc_NotImplementedError); On 2008/08/19 21:19:24, Benjamin wrote: > I ... | 16 years, 9 months ago (2008-08-19 21:40:09 UTC)#5 |
|---|
| tangyq_yoozoo.com | http://localhost:8080/3004/ | 5 years ago (2020-04-24 11:11:37 UTC)#6 |
|---|
| tangyq_yoozoo.com | http://localhost:8080/3004/ | 5 years ago (2020-04-24 11:11:38 UTC)#7 |
|---|
| tangyq_yoozoo.com | http://localhost:8080/3004/ | 5 years ago (2020-04-24 11:32:13 UTC)#8 |
|---|
| tangyq_yoozoo.com | http://localhost:8080/3004/ | 5 years ago (2020-04-24 11:32:19 UTC)#9 |
|---|
| tangyq_yoozoo.com | http://localhost:8080/3004/ | 5 years ago (2020-04-24 11:33:44 UTC)#10 |
|---|