Issue 3005: patch for bug 1878 Code Review (original) (raw)

Created:
16 years, 8 months ago by GvR

Modified:
15 years, 9 months ago

Base URL:
http://svn.python.org/view/\*checkout\*/python/trunk/

Visibility:
Public.

Description

r65874.

Patch Set 1#

Patch Set 2 : clear trailing whitespace#

Created: 16 years, 8 months ago

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
Include/object.h View 1 5 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 2

GvR Please review this, or I'll just submit it in an hour or so... 16 years, 8 months ago (2008-08-19 19:27:46 UTC)#1

Please review this, or I'll just submit it in an hour or so...

Sign in to reply to this message.

Benjamin Looks basically fine to me. http://codereview.appspot.com/3005/diff/1/2 File Include/object.h (right): http://codereview.appspot.com/3005/diff/1/2#newcode531 Line 531: Py_TPFLAGS_HAVE_VERSION_TAG; outside the ... 16 years, 8 months ago (2008-08-19 19:34:26 UTC)#2