Remove dependency from win32com.client module - Code Review (original) (raw)

Patch Set 1#

Messages

Total messages: 15

| techtonik | | 14 years, 3 months ago (2011-01-31 18:19:44 UTC)#1 | | ------------- | | ----------------------------------------------------------- |

amaury Hi, 2011/1/31 techtonik@gmail.com: > Reviewers: , > > Please review this at http://codereview.appspot.com/4080047/ [...] It ... 14 years, 3 months ago (2011-01-31 19:00:16 UTC)#2
Georg Is there a bugs.python.org issue for this? 14 years, 3 months ago (2011-01-31 19:05:29 UTC)#3
techtonik There is no b.p.o issue as it's not a bug, but a tiny copy/paste patch ... 14 years, 3 months ago (2011-01-31 20:45:44 UTC)#4
brian.curtin On Mon, Jan 31, 2011 at 14:45, techtonik@gmail.com wrote: > There is no b.p.o issue ... 14 years, 3 months ago (2011-01-31 20:49:43 UTC)#5
Martin v. Löwis What's the rationale of this change? It certainly doesn't remove the dependency from win32com.client (i.e. ... 14 years, 3 months ago (2011-02-01 00:05:07 UTC)#6
techtonik It removes the dependency from msi.py making it easier to do the rest in subsequent ... 14 years, 3 months ago (2011-02-01 07:22:57 UTC)#7
Martin v. Löwis On 2011/02/01 07:22:57, techtonik wrote: > It removes the dependency from msi.py making it easier ... 14 years, 3 months ago (2011-02-01 19:50:23 UTC)#8
techtonik On 2011/02/01 19:50:23, Martin v. Löwis wrote: > On 2011/02/01 07:22:57, techtonik wrote: > > ... 14 years, 3 months ago (2011-02-02 07:14:17 UTC)#9
Martin v. Löwis On 2011/02/02 07:14:17, techtonik wrote: > On 2011/02/01 19:50:23, Martin v. Löwis wrote: > > ... 14 years, 3 months ago (2011-02-02 07🔞33 UTC)#10
techtonik On 2011/02/02 07🔞33, Martin v. Löwis wrote: > Ah. That shouldn't be done. If anything ... 14 years, 3 months ago (2011-02-02 07:32:02 UTC)#11
Georg On 2011/02/02 07:32:02, techtonik wrote: [...] Can you PLEASE take this off python-dev and move ... 14 years, 3 months ago (2011-02-02 07:36:47 UTC)#12
techtonik On 2011/02/02 07:36:47, Georg wrote: > On 2011/02/02 07:32:02, techtonik wrote: > > [...] > ... 14 years, 3 months ago (2011-02-02 08:16:18 UTC)#13
Martin v. Löwis > It is a surprise to find builtin msilib. Why isn't it used? Originally, because ... 14 years, 3 months ago (2011-02-02 08:36:45 UTC)#14
techtonik On Wed, Feb 2, 2011 at 10:36 AM, "Martin v. Löwis" martin@v.loewis.de wrote: > >> ... 14 years, 3 months ago (2011-02-02 11:03:30 UTC)#15