Issue 4454: zlib and zipimport should use bytes not bytearray Code Review (original) (raw)

Can't Edit Can't Publish+Mail Start Review Created: 16 years, 8 months ago by gregory.p.smith Modified: 15 years, 9 months ago Reviewers: Benjamin, amaury, pitrou Base URL: http://svn.python.org/view/\*checkout\*/python/branches/py3k/ Visibility: Public.	Description see http://bugs.python.org/issue3492 Patch Set 1# Created: 16 years, 8 months ago Download[raw] [tar.bz2] Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -40 lines) Patch Lib/test/test_zlib.py View 2 chunks +8 lines, -2 lines 1 comment Download Modules/zipimport.c View 7 chunks +11 lines, -11 lines 0 comments Download Modules/zlibmodule.c View 20 chunks +27 lines, -27 lines 0 comments Download Messages Total messages: 2 Expand All Messages | Collapse All Messages gregory.p.smith 16 years, 8 months ago (2008-09-05 00:07:03 UTC)#1 Sign in to reply to this message. Benjamin Looks pretty good. Just one comment. http://codereview.appspot.com/4454/diff/1/2 File Lib/test/test_zlib.py (right): http://codereview.appspot.com/4454/diff/1/2#newcode157 Line 157: self.assertEqual(type(decombuf), bytes) ... 16 years, 8 months ago (2008-09-05 00:36:22 UTC)#2 Looks pretty good. Just one comment. http://codereview.appspot.com/4454/diff/1/2 File Lib/test/test_zlib.py (right): http://codereview.appspot.com/4454/diff/1/2#newcode157 Line 157: self.assertEqual(type(decombuf), bytes) I think assert_(isinstance(decombuf, bytes)) should be used. Sign in to reply to this message. Expand All Messages	Collapse All Messages

Issue 4454: zlib and zipimport should use bytes not bytearray - issue3492
Created 16 years, 8 months ago by gregory.p.smith
Modified 15 years, 9 months ago
Reviewers: pitrou_free.fr, amaury, Benjamin
Base URL: http://svn.python.org/view/\*checkout\*/python/branches/py3k/
Comments: 1