Multi with statement - Code Review (original) (raw)

All done, I guess.

http://codereview.appspot.com/53094/diff/1/9 File Lib/test/test_compiler.py (right):

http://codereview.appspot.com/53094/diff/1/9#newcode186 Line 186: self.assertEquals(dct.get('result'), 1) On 2009/05/02 18:22:06, Benjamin wrote:

Why using .get() here?

Following the above example. Probably to not get an error but a test failure if it isn't there.

http://codereview.appspot.com/53094/diff/1/7 File Lib/test/test_with.py (right):

http://codereview.appspot.com/53094/diff/1/7#newcode657 Line 657: class NestedWith(unittest.TestCase): On 2009/05/02 18:22:06, Benjamin wrote:

You should test that the second's exit is called even if the first one raises.

Done.

http://codereview.appspot.com/53094/diff/1/3 File Python/ast.c (right):

http://codereview.appspot.com/53094/diff/1/3#newcode3045 Line 3045: assert(TYPE(n) == with_stmt); On 2009/05/02 18:22:06, Benjamin wrote:

REQ() is better here.

It was already there, but Done.