lean and mean - Code Review (original) (raw)
Description
Per discussions on Python-3000, I've stipped range down to a bare minimum. Here's an overview of the patch: 1. No slicing. 2. Length is computed in constructor and is a PyLong in the object's struct. __len__ simply tries to convert it to a Py_ssize_t. 3. start, stop, and, step are exposed as attributes
Patch Set 1#
Patch Set 2 : use PyMemberDef#
Patch Set 3 : in response to reviews#
Patch Set 4 : __len__ is back!#
Patch Set 5 : address more concerns#
| Unified diffs | Side-by-side diffs | Delta from patch set | Stats (+113 lines, -117 lines) | Patch | |||
|---|---|---|---|---|---|---|---|
 |
Lib/ctypes/test/test_slicing.py | View | 4 | 2 chunks | +8 lines, -8 lines | 0 comments | Download |
|
Lib/test/pickletester.py | View | 4 | 1 chunk | +1 line, -1 line | 0 comments | Download |
|
Lib/test/seq_tests.py | View | 4 | 1 chunk | +1 line, -1 line | 0 comments | Download |
|
Lib/test/test_deque.py | View | 4 | 1 chunk | +1 line, -1 line | 0 comments | Download |
|
Lib/test/test_enumerate.py | View | 4 | 1 chunk | +1 line, -1 line | 0 comments | Download |
|
Lib/test/test_heapq.py | View | 4 | 1 chunk | +1 line, -1 line | 0 comments | Download |
|
Lib/test/test_mutants.py | View | 4 | 1 chunk | +2 lines, -2 lines | 0 comments | Download |
|
Lib/test/test_operator.py | View | 4 | 2 chunks | +2 lines, -2 lines | 0 comments | Download |
|
Lib/test/test_random.py | View | 4 | 3 chunks | +4 lines, -4 lines | 0 comments | Download |
|
Lib/test/test_range.py | View | 1 2 3 4 | 1 chunk | +28 lines, -5 lines | 0 comments | Download |
|
Lib/test/test_set.py | View | 4 | 3 chunks | +3 lines, -3 lines | 0 comments | Download |
|
Lib/test/test_trace.py | View | 4 | 2 chunks | +2 lines, -2 lines | 0 comments | Download |
|
Objects/rangeobject.c | View | 1 2 3 4 | 20 chunks | +59 lines, -86 lines | 0 comments | Download |
Messages
Total messages: 9