open (original) (raw)

Code Review for open

Prepared by: bpb on Thu Mar 1 17:14:15 PST 2018
Workspace: /Users/bpb/Work/CoreLibs/jdk/jdk/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version: 49114
Summary of changes: 148 lines changed: 29 ins; 105 del; 14 mod; 537 unchg
Patch of changes: <open.patch>
Legend: Modified file Deleted file New file

[Cdiffs](make/test/JtregNativeJdk.gmk.cdiff.html) [Udiffs](make/test/JtregNativeJdk.gmk.udiff.html) [Sdiffs](make/test/JtregNativeJdk.gmk.sdiff.html) [Frames](make/test/JtregNativeJdk.gmk.frames.html) [Old](make/test/JtregNativeJdk.gmk-.html) [New](make/test/JtregNativeJdk.gmk.html) [Patch](make/test/JtregNativeJdk.gmk.patch) [Raw](raw%5Ffiles/new/make/test/JtregNativeJdk.gmk) make/test/JtregNativeJdk.gmk

7 lines changed: 6 ins; 0 del; 1 mod; 100 unchg

[Cdiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java.cdiff.html) [Udiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java.udiff.html) [Sdiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java.sdiff.html) [Frames](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java.frames.html) [Old](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java-.html) [New](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java.html) [Patch](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java) test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java

10 lines changed: 0 ins; 7 del; 3 mod; 115 unchg

[Cdiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java.cdiff.html) [Udiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java.udiff.html) [Sdiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java.sdiff.html) [Frames](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java.frames.html) [Old](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java-.html) [New](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java.html) [Patch](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java) test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java

2 lines changed: 0 ins; 0 del; 2 mod; 151 unchg

[Cdiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/README.cdiff.html) [Udiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/README.udiff.html) [Sdiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/README.sdiff.html) [Frames](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/README.frames.html) [Old](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/README-.html) [New](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/README.html) [Patch](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/README.patch) [Raw](raw%5Ffiles/new/test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/README) test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/README

29 lines changed: 2 ins; 19 del; 8 mod; 6 unchg

[Cdiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c.cdiff.html) [Udiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c.udiff.html) [Sdiffs](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c.sdiff.html) [Frames](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c.frames.html) [Old](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c-.html) [New](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c.html) [Patch](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c.patch) [Raw](raw%5Ffiles/new/test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c) test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c (was test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.c)

21 lines changed: 21 ins; 0 del; 0 mod; 165 unchg

------ ------ ------ ------[Old](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Makefile-.html) ---[Patch](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Makefile.patch) --- test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Makefile

79 lines changed: 0 ins; 79 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/linux-i586/libLauncher.so-.html) ---[Patch](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/linux-i586/libLauncher.so.patch) --- test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/linux-i586/libLauncher.so

Unexpected Error occurred reading `diff -e old/test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/linux-i586/libLauncher.so /dev/null`: $?=0, err= 1

------ ------ ------ ------[Old](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so-.html) ---[Patch](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so.patch) --- test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so

Unexpected Error occurred reading `diff -e old/test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so /dev/null`: $?=0, err= 1

------ ------ ------ ------[Old](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparcv9/libLauncher.so-.html) ---[Patch](test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparcv9/libLauncher.so.patch) --- test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparcv9/libLauncher.so

Unexpected Error occurred reading `diff -e old/test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparcv9/libLauncher.so /dev/null`: $?=0, err= 1


This code review page was prepared using /usr/local/bin/webrev.ksh(vers 25.16-hg+openjdk.java.net).