jdk (original) (raw)
Code Review for jdk
Prepared by: | robm on Mon Dec 17 18:01:01 GMT 2012 |
---|---|
Workspace: | /suspool/home/rob/7/forest/jdk |
Compare against: | ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk |
Compare against version: | 5548 |
Summary of changes: | 178 lines changed: 26 ins; 99 del; 53 mod; 1743 unchg |
Patch of changes: | <jdk.patch> |
Legend: | Modified file Deleted file New file |
[Cdiffs](src/solaris/native/java/lang/java%5Fprops%5Fmacosx.c.cdiff.html) [Udiffs](src/solaris/native/java/lang/java%5Fprops%5Fmacosx.c.udiff.html) [Sdiffs](src/solaris/native/java/lang/java%5Fprops%5Fmacosx.c.sdiff.html) [Frames](src/solaris/native/java/lang/java%5Fprops%5Fmacosx.c.frames.html) [Old](src/solaris/native/java/lang/java%5Fprops%5Fmacosx.c-.html) [New](src/solaris/native/java/lang/java%5Fprops%5Fmacosx.c.html) [Patch](src/solaris/native/java/lang/java%5Fprops%5Fmacosx.c.patch) [Raw](raw%5Ffiles/new/src/solaris/native/java/lang/java%5Fprops%5Fmacosx.c)
src/solaris/native/java/lang/java_props_macosx.c
rev 5549 : 8003898: X11 toolkit can be chosen as the default toolkit Summary: XToolkit is not selected for any values of system-wide environment variables (ex. DISPLAY). Reviewed-by: anthony, art
5 lines changed: 0 ins; 5 del; 0 mod; 345 unchg
[Cdiffs](test/ProblemList.txt.cdiff.html) [Udiffs](test/ProblemList.txt.udiff.html) [Sdiffs](test/ProblemList.txt.sdiff.html) [Frames](test/ProblemList.txt.frames.html) [Old](test/ProblemList.txt-.html) [New](test/ProblemList.txt.html) [Patch](test/ProblemList.txt.patch) [Raw](raw%5Ffiles/new/test/ProblemList.txt)
test/ProblemList.txt
rev 5550 : 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) Summary: In problem tests detection of AWT headless mode was introduced or AWT dependence was removed. Reviewed-by: alanb
38 lines changed: 0 ins; 38 del; 0 mod; 509 unchg
[Cdiffs](test/demo/jvmti/mtrace/TraceJFrame.java.cdiff.html) [Udiffs](test/demo/jvmti/mtrace/TraceJFrame.java.udiff.html) [Sdiffs](test/demo/jvmti/mtrace/TraceJFrame.java.sdiff.html) [Frames](test/demo/jvmti/mtrace/TraceJFrame.java.frames.html) [Old](test/demo/jvmti/mtrace/TraceJFrame.java-.html) [New](test/demo/jvmti/mtrace/TraceJFrame.java.html) [Patch](test/demo/jvmti/mtrace/TraceJFrame.java.patch) [Raw](raw%5Ffiles/new/test/demo/jvmti/mtrace/TraceJFrame.java)
test/demo/jvmti/mtrace/TraceJFrame.java
rev 5550 : 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) Summary: In problem tests detection of AWT headless mode was introduced or AWT dependence was removed. Reviewed-by: alanb
16 lines changed: 5 ins; 0 del; 11 mod; 41 unchg
[Cdiffs](test/java/io/Serializable/resolveClass/deserializeButton/Foo.java.cdiff.html) [Udiffs](test/java/io/Serializable/resolveClass/deserializeButton/Foo.java.udiff.html) [Sdiffs](test/java/io/Serializable/resolveClass/deserializeButton/Foo.java.sdiff.html) [Frames](test/java/io/Serializable/resolveClass/deserializeButton/Foo.java.frames.html) [Old](test/java/io/Serializable/resolveClass/deserializeButton/Foo.java-.html) [New](test/java/io/Serializable/resolveClass/deserializeButton/Foo.java.html) [Patch](test/java/io/Serializable/resolveClass/deserializeButton/Foo.java.patch) [Raw](raw%5Ffiles/new/test/java/io/Serializable/resolveClass/deserializeButton/Foo.java)
test/java/io/Serializable/resolveClass/deserializeButton/Foo.java
rev 5550 : 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) Summary: In problem tests detection of AWT headless mode was introduced or AWT dependence was removed. Reviewed-by: alanb
9 lines changed: 1 ins; 2 del; 6 mod; 52 unchg
[Cdiffs](test/java/io/Serializable/resolveClass/deserializeButton/Test.java.cdiff.html) [Udiffs](test/java/io/Serializable/resolveClass/deserializeButton/Test.java.udiff.html) [Sdiffs](test/java/io/Serializable/resolveClass/deserializeButton/Test.java.sdiff.html) [Frames](test/java/io/Serializable/resolveClass/deserializeButton/Test.java.frames.html) [Old](test/java/io/Serializable/resolveClass/deserializeButton/Test.java-.html) [New](test/java/io/Serializable/resolveClass/deserializeButton/Test.java.html) [Patch](test/java/io/Serializable/resolveClass/deserializeButton/Test.java.patch) [Raw](raw%5Ffiles/new/test/java/io/Serializable/resolveClass/deserializeButton/Test.java)
test/java/io/Serializable/resolveClass/deserializeButton/Test.java
rev 5550 : 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) Summary: In problem tests detection of AWT headless mode was introduced or AWT dependence was removed. Reviewed-by: alanb
1 line changed: 0 ins; 0 del; 1 mod; 41 unchg
[Cdiffs](test/java/io/Serializable/resolveClass/deserializeButton/run.sh.cdiff.html) [Udiffs](test/java/io/Serializable/resolveClass/deserializeButton/run.sh.udiff.html) [Sdiffs](test/java/io/Serializable/resolveClass/deserializeButton/run.sh.sdiff.html) [Frames](test/java/io/Serializable/resolveClass/deserializeButton/run.sh.frames.html) [Old](test/java/io/Serializable/resolveClass/deserializeButton/run.sh-.html) [New](test/java/io/Serializable/resolveClass/deserializeButton/run.sh.html) [Patch](test/java/io/Serializable/resolveClass/deserializeButton/run.sh.patch) [Raw](raw%5Ffiles/new/test/java/io/Serializable/resolveClass/deserializeButton/run.sh)
test/java/io/Serializable/resolveClass/deserializeButton/run.sh
rev 5550 : 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) Summary: In problem tests detection of AWT headless mode was introduced or AWT dependence was removed. Reviewed-by: alanb
1 line changed: 0 ins; 0 del; 1 mod; 49 unchg
[Cdiffs](test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java.cdiff.html) [Udiffs](test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java.udiff.html) [Sdiffs](test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java.sdiff.html) [Frames](test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java.frames.html) [Old](test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java-.html) [New](test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java.html) [Patch](test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java.patch) [Raw](raw%5Ffiles/new/test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java)
test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java
rev 5551 : 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung
30 lines changed: 5 ins; 18 del; 7 mod; 51 unchg
[Cdiffs](test/java/lang/Throwable/LegacyChainedExceptionSerialization.java.cdiff.html) [Udiffs](test/java/lang/Throwable/LegacyChainedExceptionSerialization.java.udiff.html) [Sdiffs](test/java/lang/Throwable/LegacyChainedExceptionSerialization.java.sdiff.html) [Frames](test/java/lang/Throwable/LegacyChainedExceptionSerialization.java.frames.html) [Old](test/java/lang/Throwable/LegacyChainedExceptionSerialization.java-.html) [New](test/java/lang/Throwable/LegacyChainedExceptionSerialization.java.html) [Patch](test/java/lang/Throwable/LegacyChainedExceptionSerialization.java.patch) [Raw](raw%5Ffiles/new/test/java/lang/Throwable/LegacyChainedExceptionSerialization.java)
test/java/lang/Throwable/LegacyChainedExceptionSerialization.java
rev 5551 : 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung
3 lines changed: 0 ins; 1 del; 2 mod; 56 unchg
[Cdiffs](test/java/lang/management/CompilationMXBean/Basic.java.cdiff.html) [Udiffs](test/java/lang/management/CompilationMXBean/Basic.java.udiff.html) [Sdiffs](test/java/lang/management/CompilationMXBean/Basic.java.sdiff.html) [Frames](test/java/lang/management/CompilationMXBean/Basic.java.frames.html) [Old](test/java/lang/management/CompilationMXBean/Basic.java-.html) [New](test/java/lang/management/CompilationMXBean/Basic.java.html) [Patch](test/java/lang/management/CompilationMXBean/Basic.java.patch) [Raw](raw%5Ffiles/new/test/java/lang/management/CompilationMXBean/Basic.java)
test/java/lang/management/CompilationMXBean/Basic.java
rev 5551 : 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung
4 lines changed: 0 ins; 2 del; 2 mod; 79 unchg
[Cdiffs](test/java/lang/reflect/Generics/Probe.java.cdiff.html) [Udiffs](test/java/lang/reflect/Generics/Probe.java.udiff.html) [Sdiffs](test/java/lang/reflect/Generics/Probe.java.sdiff.html) [Frames](test/java/lang/reflect/Generics/Probe.java.frames.html) [Old](test/java/lang/reflect/Generics/Probe.java-.html) [New](test/java/lang/reflect/Generics/Probe.java.html) [Patch](test/java/lang/reflect/Generics/Probe.java.patch) [Raw](raw%5Ffiles/new/test/java/lang/reflect/Generics/Probe.java)
test/java/lang/reflect/Generics/Probe.java
rev 5551 : 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung
3 lines changed: 0 ins; 1 del; 2 mod; 131 unchg
[Cdiffs](test/java/lang/reflect/Proxy/ClassRestrictions.java.cdiff.html) [Udiffs](test/java/lang/reflect/Proxy/ClassRestrictions.java.udiff.html) [Sdiffs](test/java/lang/reflect/Proxy/ClassRestrictions.java.sdiff.html) [Frames](test/java/lang/reflect/Proxy/ClassRestrictions.java.frames.html) [Old](test/java/lang/reflect/Proxy/ClassRestrictions.java-.html) [New](test/java/lang/reflect/Proxy/ClassRestrictions.java.html) [Patch](test/java/lang/reflect/Proxy/ClassRestrictions.java.patch) [Raw](raw%5Ffiles/new/test/java/lang/reflect/Proxy/ClassRestrictions.java)
test/java/lang/reflect/Proxy/ClassRestrictions.java
rev 5551 : 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung
35 lines changed: 3 ins; 18 del; 14 mod; 155 unchg
[Cdiffs](test/java/util/Collections/EmptyIterator.java.cdiff.html) [Udiffs](test/java/util/Collections/EmptyIterator.java.udiff.html) [Sdiffs](test/java/util/Collections/EmptyIterator.java.sdiff.html) [Frames](test/java/util/Collections/EmptyIterator.java.frames.html) [Old](test/java/util/Collections/EmptyIterator.java-.html) [New](test/java/util/Collections/EmptyIterator.java.html) [Patch](test/java/util/Collections/EmptyIterator.java.patch) [Raw](raw%5Ffiles/new/test/java/util/Collections/EmptyIterator.java)
test/java/util/Collections/EmptyIterator.java
rev 5551 : 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung
11 lines changed: 5 ins; 2 del; 4 mod; 138 unchg
[Cdiffs](test/java/util/logging/LoggingDeadlock4.java.cdiff.html) [Udiffs](test/java/util/logging/LoggingDeadlock4.java.udiff.html) [Sdiffs](test/java/util/logging/LoggingDeadlock4.java.sdiff.html) [Frames](test/java/util/logging/LoggingDeadlock4.java.frames.html) [Old](test/java/util/logging/LoggingDeadlock4.java-.html) [New](test/java/util/logging/LoggingDeadlock4.java.html) [Patch](test/java/util/logging/LoggingDeadlock4.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/LoggingDeadlock4.java)
test/java/util/logging/LoggingDeadlock4.java
rev 5551 : 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung
22 lines changed: 7 ins; 12 del; 3 mod; 96 unchg
This code review page was prepared using /suspool/home/rob/scripts/webrev/webrev(vers 23.18-hg).